Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Order of the ZIP code and city field #3663

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

aragon999
Copy link
Contributor

1. Why is this change necessary?

https://forum.shopware.com/t/im-registrierungsformular-steht-ort-vor-plz/103671/4
46ee060#diff-bec516e908622f4a6c0862196e64e5a62997373658b915cd3153f73fd04253ff

2. What does this change do, exactly?

Interchange the order and for good measure, also add blocks.

3. Describe each step to reproduce the issue or behaviour.

-

4. Please link to the relevant issues (if any).

-

5. Checklist

  • I have rebased my changes to remove merge conflicts
  • I have written tests and verified that they fail without my change
  • I have created a changelog file with all necessary information about my changes
  • I have written or adjusted the documentation according to my changes
  • This change has comments for package types, values, functions, and non-obvious lines of code
  • I have read the contribution requirements and fulfil them.

@aragon999
Copy link
Contributor Author

Maybe the "fix" is not sufficient, as it has been pointed out, that for some countries it might be needed that the order is reversed. Not sure if the configuration option should be added again (and if so, at which place?).

@mstegmeyer
Copy link
Contributor

Just swapping the fields is not the solution, I believe. We should either bring back the option that was removed due to the new address formatting or apply the new address formatting to the registration form as well (difficult, due to the country selection being at the end).

@mstegmeyer mstegmeyer self-assigned this Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants