Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Correct display of long names of child items in administration order #3656

Conversation

tschosch51
Copy link
Contributor

1. Why is this change necessary?

Broken:
broken
Fixed:
fixed

2. What does this change do, exactly?

Change scss

3. Describe each step to reproduce the issue or behaviour.

Open the modal of a product with child line items in the order in the administration

4. Please link to the relevant issues (if any).

5. Checklist

  • I have rebased my changes to remove merge conflicts
  • I have written tests and verified that they fail without my change
  • I have created a changelog file with all necessary information about my changes
  • I have written or adjusted the documentation according to my changes
  • This change has comments for package types, values, functions, and non-obvious lines of code
  • I have read the contribution requirements and fulfil them.

@mstegmeyer
Copy link
Contributor

Hey @tschosch51, thanks for the fix! Is it also realistic to fix the misalignment of the prices and the quantities? Or is that a completely new can of worms? 😉

@mstegmeyer
Copy link
Contributor

Your new display: table changes do not seem to have that effect. In addition, with only small line item labels, this now results in a too small table. Please at least add a width: 100% to the table, so it fills the whole modal.

@tschosch51 tschosch51 force-pushed the fix/admin-order-overview-child-line-items branch from b237467 to 31a8d79 Compare April 23, 2024 09:31
@shopware-github-importer
Copy link

Hello,

thank you for creating this pull request.
I have opened an issue on our Issue Tracker for you. See the issue link: https://issues.shopware.com/issues/NEXT-35665

Please use this issue to track the state of your pull request.

@mstegmeyer
Copy link
Contributor

Your PR has been merged, thank you for your contribution 💙 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants