Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove data from filesystems when plugins are uninstalled #3600

Draft
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

JoshuaBehrens
Copy link
Contributor

@JoshuaBehrens JoshuaBehrens commented Mar 9, 2024

1. Why is this change necessary?

@mitelg once said

#206 (comment)

Are there already cleanup tasks that delete plugin directories on life cycle?

not yet 😊

So we should clean files up like assets and migrations, right?

Copy link

github-actions bot commented Mar 9, 2024

Fails
🚫 The title `Remove data from filesystems when plugins are uninstalled` does not match our requirements. Example: NEXT-00000 - My Title
Warnings
⚠️ The Pull Request doesn't contain any changelog file

@keulinho
Copy link
Contributor

Hey @JoshuaBehrens,

thanks for the PR!
We were just wondering if this may lead to surprising cases, because this now deletes stuff "magically". What do you think about making this more explicit by requiring the plugins to opt-in to this behaviour, e.g. by a clearFilesystemOnInstall() method on the base class?

Also the case for the handling with the additional bundles is pretty similiar then your other PR where you fixed it for the assets, maybe it makes sense to combine the two approaches somehow, as they are also conceptually quite similiar

@tinect
Copy link
Contributor

tinect commented Apr 12, 2024

I think, the user should also decide whether the filesystems should be deleted. E.g. related private filesystem may contain important files for business.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants