You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the validation is not correct, such that the id of the product review will be compared with the customer id. Therefore it is possible to create multiple reviews per product (if one is omitting the id, which usually does not happen in the normal storefront). Furthermore it would be possible to overwrite the name or email from the request, which also does not happen.
2. What does this change do, exactly?
Fix the validation and always use the values from the customer object and cleanup some other stuff.
3. Describe each step to reproduce the issue or behaviour.
-
4. Please link to the relevant issues (if any).
-
5. Checklist
I have rebased my changes to remove merge conflicts
I have written tests and verified that they fail without my change
I have created a changelog file with all necessary information about my changes
I have written or adjusted the documentation according to my changes
This change has comments for package types, values, functions, and non-obvious lines of code
I have read the contribution requirements and fulfil them.
Hi @aragon999 , thanks for your contribution. I can understand the benefits for some customers. If we adopt this functionality, we would like to offer the merchant a choice in the form of a setting. I would suggest to add the setting on Settings > Products
@leduc92 a setting for what exactly do you mean? :-)
At the moment, the storefront does not offer the functionality, to create multiple reviews. Once the review is created, it is only possible to edit the review and the same customer cannot add another review. It is only possible to add a second review, when one is directly using the route, and only because of a bug in the route. So I am not sure, because adding multiple reviews, would also require some more frontend work.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
aragon999
force-pushed
the
fix/review-save-validation
branch
from
1. Why is this change necessary?
Currently the validation is not correct, such that the
idof the product review will be compared with the customer id. Therefore it is possible to create multiple reviews per product (if one is omitting the id, which usually does not happen in the normal storefront). Furthermore it would be possible to overwrite the name or email from the request, which also does not happen.2. What does this change do, exactly?
Fix the validation and always use the values from the customer object and cleanup some other stuff.
3. Describe each step to reproduce the issue or behaviour.
-
4. Please link to the relevant issues (if any).
-
5. Checklist