Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[framework] Fix error for less>=3.0.1 #1291

Closed
wants to merge 1 commit into from

Conversation

hason
Copy link
Contributor

@hason hason commented Aug 5, 2019

less/less.js#3188

Q A
Description, reason for the PR less.js < 3.0 automaticaly detects if imported file is less or css. But from 3.0.1 it should be defined by (css) before url to avoid errors during build, see less/less.js#3188
New feature No
BC breaks No
Fixes issues -
Have you read and signed our License Agreement for contributions? Yes

Copy link
Contributor

@TomasGottvald TomasGottvald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great solution. Thank you for your PR.

@vitek-rostislav
Copy link
Contributor

vitek-rostislav commented Aug 9, 2019

Hi @hason, thanks for the PR 👍 could anyone please provide a better description for a person like me? I am no frontend developer, however, I am trying to understand this. Does it mean something (import of fonts) is broken at the moment? In such a case the PR should be targetted to 8.0 branch as the problem is there as well, am I right @tomshopsys?

Btw, I have updated the description of the PR - there is no BC break in this change 😉

@TomasGottvald
Copy link
Contributor

@vitek-rostislav
Description of problem: less.js < 3.0 automaticaly detects if imported file is less or css. But from 3.0.1 it should be defined by (css) before url to avoid errors during build.

And is it true to add this PR to 8.0 too.

@vitek-rostislav vitek-rostislav changed the title Fix error for less>=3.0.1 [framework] Fix error for less>=3.0.1 Aug 9, 2019
@vitek-rostislav vitek-rostislav changed the base branch from master to 8.0 August 9, 2019 06:30
@vitek-rostislav
Copy link
Contributor

Hi @hason, we wanted to test your modification, however, we were not able to reproduce the original problem so even though I believe your solution helps (based on the linked issue and on the fact that everything works in your branch), I am not able to confirm that.

Could you please provide us exact steps to reproduce the original problem?

@LukasHeinz LukasHeinz added the Status: info needed Issue need more information or some clarification to proceed with this issue label Aug 29, 2019
@stale
Copy link

stale bot commented Dec 10, 2019

This issue has been automatically marked as stale because there was no activity within the last 4 months (and it is quite a long time). It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Stale This issue have not been touched for some time and if it doesn't change, it will be closed soon. label Dec 10, 2019
@stale
Copy link

stale bot commented Feb 8, 2020

This issue has been automatically closed because there was no acivity within the last half a year.

@stale stale bot closed this Feb 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Stale This issue have not been touched for some time and if it doesn't change, it will be closed soon. Status: info needed Issue need more information or some clarification to proceed with this issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants