New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[framework] Fix error for less>=3.0.1 #1291
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great solution. Thank you for your PR.
Hi @hason, thanks for the PR 👍 could anyone please provide a better description for a person like me? I am no frontend developer, however, I am trying to understand this. Does it mean something (import of fonts) is broken at the moment? In such a case the PR should be targetted to Btw, I have updated the description of the PR - there is no BC break in this change 😉 |
@vitek-rostislav And is it true to add this PR to 8.0 too. |
Hi @hason, we wanted to test your modification, however, we were not able to reproduce the original problem so even though I believe your solution helps (based on the linked issue and on the fact that everything works in your branch), I am not able to confirm that. Could you please provide us exact steps to reproduce the original problem? |
This issue has been automatically marked as stale because there was no activity within the last 4 months (and it is quite a long time). It will be closed if no further activity occurs. Thank you for your contributions. |
This issue has been automatically closed because there was no acivity within the last half a year. |
less/less.js#3188
(css)
before url to avoid errors during build, see less/less.js#3188