Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split reusable content into separated components #853

Merged
merged 45 commits into from
Aug 7, 2023

Conversation

acelaya
Copy link
Member

@acelaya acelaya commented Aug 4, 2023

This PR is part of #338

Split everything that can be used on any app into @shlinkio/shlink-web-component package.

Split frontend utils and components that are required by this app and shlink-web-component into @shlinkio/shlink-frontend-kit.

@codecov
Copy link

codecov bot commented Aug 4, 2023

Codecov Report

Merging #853 (a2f3673) into develop (deca5b3) will increase coverage by 0.15%.
The diff coverage is 85.39%.

@@             Coverage Diff             @@
##           develop     #853      +/-   ##
===========================================
+ Coverage    84.61%   84.76%   +0.15%     
===========================================
  Files          189      212      +23     
  Lines        10216    10630     +414     
  Branches      1442     1464      +22     
===========================================
+ Hits          8644     9011     +367     
- Misses         156      182      +26     
- Partials      1416     1437      +21     
Files Changed Coverage Δ
shlink-frontend-kit/src/block/Message.tsx 88.88% <ø> (ø)
shlink-frontend-kit/src/block/Result.tsx 96.77% <ø> (ø)
shlink-frontend-kit/src/form/Checkbox.tsx 80.00% <ø> (ø)
shlink-frontend-kit/src/form/LabeledFormGroup.tsx 89.47% <ø> (ø)
shlink-frontend-kit/src/form/ToggleSwitch.tsx 80.00% <ø> (ø)
shlink-frontend-kit/src/navigation/NavPills.tsx 85.71% <ø> (ø)
...ink-frontend-kit/src/navigation/RowDropdownBtn.tsx 95.23% <ø> (ø)
shlink-frontend-kit/src/theme/index.ts 88.23% <0.00%> (ø)
shlink-web-component/src/api-contract/errors.ts 96.29% <ø> (ø)
shlink-web-component/src/mercure/helpers/Topics.ts 85.71% <ø> (ø)
... and 144 more

... and 29 files with indirect coverage changes

@acelaya acelaya force-pushed the feature/shlink-web-component branch from eae7eed to 9f9f3b6 Compare August 6, 2023 11:15
@github-actions
Copy link

github-actions bot commented Aug 6, 2023

@acelaya acelaya merged commit a6134c6 into shlinkio:develop Aug 7, 2023
7 checks passed
@acelaya acelaya deleted the feature/shlink-web-component branch August 7, 2023 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant