Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce remeda and replace some usages of ramda #818

Closed
wants to merge 1 commit into from

Conversation

acelaya
Copy link
Member

@acelaya acelaya commented Mar 18, 2023

Replace ramda with remeda

Closes #805

@github-actions
Copy link

@codecov-commenter
Copy link

codecov-commenter commented Mar 18, 2023

Codecov Report

Merging #818 (a5338fa) into develop (8fa61a6) will increase coverage by 0.03%.
The diff coverage is 92.59%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff             @@
##           develop     #818      +/-   ##
===========================================
+ Coverage    82.00%   82.03%   +0.03%     
===========================================
  Files          190      190              
  Lines         2212     2216       +4     
  Branches       357      358       +1     
===========================================
+ Hits          1814     1818       +4     
  Misses         106      106              
  Partials       292      292              
Impacted Files Coverage Δ
src/mercure/helpers/boundToMercureHub.tsx 68.75% <0.00%> (ø)
src/servers/ServersDropdown.tsx 87.50% <50.00%> (ø)
src/common/Home.tsx 100.00% <100.00%> (ø)
src/common/ShlinkVersions.tsx 85.71% <100.00%> (ø)
src/domains/DomainSelector.tsx 72.72% <100.00%> (ø)
src/servers/data/index.ts 80.00% <100.00%> (-1.82%) ⬇️
src/servers/helpers/ImportServersBtn.tsx 79.16% <100.00%> (ø)
src/servers/reducers/selectedServer.ts 90.90% <100.00%> (+0.90%) ⬆️
src/servers/reducers/servers.ts 86.95% <100.00%> (ø)
src/utils/utils.ts 61.53% <100.00%> (+6.99%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@acelaya acelaya changed the title Intrpduce remeade and replace some usages of ramda Intrpduce remeda and replace some usages of ramda Mar 22, 2023
@acelaya acelaya changed the title Intrpduce remeda and replace some usages of ramda Introduce remeda and replace some usages of ramda Jun 16, 2023
@acelaya
Copy link
Member Author

acelaya commented Aug 19, 2023

Going to remove ramda, not replace it with something else.

@acelaya acelaya closed this Aug 19, 2023
@acelaya acelaya deleted the feature/remeda branch August 19, 2023 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider migrating from Ramda to Remeda
2 participants