Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Claymores & Mine Tweaks #2988

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from
Draft

Conversation

Sun-Soaked
Copy link
Contributor

@Sun-Soaked Sun-Soaked commented May 13, 2024

About The Pull Request

TODO:

  • Actually implement claymores (should we let players have them?)(Cargo?)

  • Remove weird sprite shim I made when world icons are merged

  • Sprites (this time we actually need them since the placeholder ones are tgmc & I didn't ask for permission)

Adds Mines that explode when an object passes in front of them & fire an ammo casing in that direction.
Adds claymores as an implemented example of this- short range, shreds people at point blank.

I had to do some tweaking behind the scenes to implement mobless casing firing- but I'm pleased to say that fire_casing() can now deal emotionally with being handed a null user.

Also minorly tweaks explosion devastation, so heavy explosions can only strip tiles that have already been damaged
You can still immediately strip tiles with devastating explosions

Why It's Good For The Game

FRONT TOWARDS ENEMY

Changelog

馃啈
add: Directional Mines
add: Claymores.
balance: explosions now only strip to space when a tile is already damaged
tweak: Prox mines explode from slightly further away & no longer activate through walls.
fix: Multiple mines can no longer be stacked on a tile
code: fire_casing() can now be called by non-mobs, allowing objects to shoot casings.
/:cl:

main pr body
-dir mines
-claymores
-fire_casing now works without a mob
-mines can no longer be placed on a tile that already has a deployed mine
@github-actions github-actions bot added Sprites A bikeshed full of soulless bikes. Code change Watch something violently break. labels May 13, 2024
live mine was trying to draw tripwires in nullspace after being move()'d there
Copy link
Contributor

@FalloutFalcon FalloutFalcon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code seems fine!

@Sun-Soaked
Copy link
Contributor Author

this could use a testmerge now that they're accessible via cargo, I want to see how the balance shakes out

?" can I get a : right now... : right now...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code change Watch something violently break. Sprites A bikeshed full of soulless bikes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants