Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raises Sarathi max age to 175. #2959

Merged
merged 9 commits into from
May 20, 2024
Merged

Conversation

Sadhorizon
Copy link
Contributor

About The Pull Request

Title.

Why It's Good For The Game

Quoting the wiki,

Sarathi have a longer lifespan than humans, with the oldest typically reaching 175 years old.

I assume lore people forgor to update it code-wise.

Changelog

馃啈
tweak: Sarathi max age is now 175.
/:cl:

@github-actions github-actions bot added the Code change Watch something violently break. label May 5, 2024
@Sadhorizon
Copy link
Contributor Author

Sadhorizon commented May 5, 2024

Wuh. Why so many commits... did I click something wrong?

@Anticept
Copy link
Contributor

Anticept commented May 5, 2024

Not an issue for this PR. You probably created a branch based on another branch that has that b929352 commit, pulled on it, or edited master...

However, changed files doesnt say there's any differences so it should be a simple fix with a squash when merged.

@Sadhorizon
Copy link
Contributor Author

Not an issue for this PR. You probably created a branch based on another branch that has that b929352 commit.

Nope, I'm just a dummy :D

@thgvr thgvr enabled auto-merge May 13, 2024 00:19
@thgvr thgvr added this pull request to the merge queue May 13, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 13, 2024
@retlaw34 retlaw34 added this pull request to the merge queue May 20, 2024
Merged via the queue into shiptest-ss13:master with commit 1bc6173 May 20, 2024
14 checks passed
MysticalFaceLesS pushed a commit to CeladonSS13/Shiptest that referenced this pull request May 25, 2024
<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request
Title.
<!-- Describe The Pull Request. Please be sure every change is
documented or this can delay review and even discourage maintainers from
merging your PR! -->

## Why It's Good For The Game
Quoting [the wiki](https://shiptest.net/wiki/Sarathi), 
> Sarathi have a longer lifespan than humans, with the oldest typically
reaching 175 years old.

I assume lore people forgor to update it code-wise.

<!-- Please add a short description of why you think these changes would
benefit the game. If you can't justify it in words, it might not be
worth adding. -->

## Changelog

:cl:
tweak: Sarathi max age is now 175.
/:cl:

<!-- Both :cl:'s are required for the changelog to work! You can put
your name to the right of the first :cl: if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code change Watch something violently break.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants