Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds tech shells to the outpost market, recipe rebalance and buffs #2958

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

Gristlebee
Copy link
Contributor

@Gristlebee Gristlebee commented May 5, 2024

About The Pull Request

Adds unloaded techshells to the outpost market, 7 shells for 175 credits.

Recipe changes

  • Scatter Laser: 1 Adv Capacitor, 1 Adv Microlaser -> 1 Capacitor, 3 Microlaser, 1 power cell, 5u lithium
  • Pulse Slug: 2 Adv Capacitor, 1 Ultra Microlaser -> 3 Capacitor, 1 Microlaser, 1 power cell, 5u lithium
  • Scatter Ion: 1 Ansible Crystal, 1 Ultra Microlaser -> 2 Capacitor, 2 Microlaser, 1 scanning module, 5u iron, 5u uranium
  • Dragonsbreath : 5u phosphorous -> 10u phosphorous

Changes the scatter ion desc to reflect the new recipe.

Ammo changes

Scatter laser and ion now fires 8 pellets, instead of 4, variance is 25 from 35
Dragonsbreath now fires 8 pellets instead of 4, deals 8 damage up from 5, variance is 45 from 35.

Why It's Good For The Game

These techshells were pretty underwhelming for what they were, and pretty heavily gated behind RND. For all the effort of researching and printing techshells with scatter lasers for example, you'd get a 60 damage shell on par with an improvised buckshot you made with scrap.

These changes should make them more comparable with standard ammunition and not so reliant on needing RND. I think techshells are pretty interesting and adds a versatile combat option.

Changelog

🆑
add: Techshell box
add: Techshells to the outpost market for 175 credits
tweak: Scatter ion description
balance: Techshell recipes no longer require higher tier stock parts, adjusts scatter laser, scatter ion, dragonsbreath and pulse slug recipes
balance: Buffs scatter lasers, scatter ion and dragonsbreath
/:cl:

@Gristlebee Gristlebee requested a review from a team as a code owner May 5, 2024 04:58
@github-actions github-actions bot added DME Edit Sprites A bikeshed full of soulless bikes. Code change Watch something violently break. labels May 5, 2024
@thgvr
Copy link
Member

thgvr commented May 5, 2024

personally i think tech shells are lame and would rather see them removed

@Imaginos16
Copy link
Member

Imaginos16 commented May 5, 2024

Personally this is a goated as hell PR and it gives tech shells a proper niche now instead of it being gatekept by RND shenanigans. If only the other RND-gated Roumain guns could follow suit.

@Imaginos16
Copy link
Member

If only the other RND-gated Roumain guns could follow suit.

Actually this is quite the idea for a PR now that I think about it, time to cook.

@thgvr
Copy link
Member

thgvr commented May 5, 2024

I also don't really want to see pulse slugs taking down walls as well as the super turf fires

@Gristlebee
Copy link
Contributor Author

I also don't really want to see pulse slugs taking down walls as well as the super turf fires

Pulse shots dont break walls anymore after #2315. The turf fires from the pulse slug is also handled by a proc, so I can tone down it's strength if that's an issue.

pellets = 4
variance = 35
pellets = 8
variance = 25

/obj/item/ammo_casing/shotgun/laserscatter
name = "scatter laser shell"
desc = "An advanced shotgun shell that uses a micro laser to replicate the effects of a scatter laser weapon in a ballistic package."
icon_state = "laser"
projectile_type = /obj/projectile/beam/weak
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

15 damage -5 AP compared to buckshot 13 damage -35 AP

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did some testing, and against a standard armor vest, an individual weak beam deals about 10.3 damage vs a buckshot pellet dealing 7. So about 83 damage laser scatter vs 56 damage from buckshot assuming every shot hits. It's a decent chunk of extra damage, but not a one hit crit.

Copy link
Contributor

@Apogee-dev Apogee-dev May 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldnt compare laser shells to buckshot personally. In terms of niche theyre closer to slugs as an anti-armor option. Which they should definitely outclass at point blank range but I’d like to see how they stack up at different ranges.

@github-actions github-actions bot added the Merge Conflict Use Git Hooks, you're welcome. label May 20, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Signed-off-by: Gristlebee <56049844+Gristlebee@users.noreply.github.com>
@github-actions github-actions bot removed Merge Conflict Use Git Hooks, you're welcome. DME Edit labels May 21, 2024
/datum/supply_pack/ammo/techshells
name = "Unloaded Shotgun Technological Shells Crate"
desc = "Contains a box of 7 versatile tech shells, capable of producing a variety of deadly effects for any situation. Some assembly required."
cost = 175
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

20 per buckshot or slug
25 per tech shell..
I would prefer if they cost more, the crafting ingredients aren't enough to affect the balance

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

upped it by another 5, it's now 30 per tech shell.

@FalloutFalcon FalloutFalcon added the Test Merge Required They'll have to do it for free. label May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code change Watch something violently break. Sprites A bikeshed full of soulless bikes. Test Merge Required They'll have to do it for free.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants