Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New version of json (2.7.2) broke the build #150

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

depfu[bot]
Copy link
Contributor

@depfu depfu bot commented Apr 11, 2024

We've tested your project with an updated dependency and the build failed.

This version is either within the version range you specified or you haven't specified a version/range. To be able to test your project with the new version, we've taken the liberty of pinning the version for this branch and pull request.

name version specification new version
json >= 1.8.0 2.7.2

Unfortunately, we encountered failing tests after pinning. This means that this new version is not compatible with your project and the test failure will potentially also happen on fresh installs.

If you have correctly specified a semantic versioning version range, you should probably also file an issue with the upstream project as they might have released an update that's breaking SemVer rules, which is not cool. (But then again, not all projects explicitly follow SemVer)

We've left the pull request open for you to investigate this issue. Please don't merge it as is, because, again, we've pinned the version of json for this test run.

What changed?

✳️ json (>= 1.8.0 → 2.7.2) · Repo · Changelog

Release Notes

2.7.2

What's Changed

  • Use rb_sym2str instead of SYM2ID by @jhawthorn in #561
  • Fix memory leak when exception is raised during JSON generation by @peterzhu2118 in #574
  • Remove references to "19" methods in JRuby by @headius in #576
  • Make OpenStruct support as optional by @hsbt in #565
  • Autoload JSON::GenericObject to avoid require ostruct warning in Ruby 3.4 by @tompng in #577
  • Warn to install ostruct if json couldn't load it by @hsbt in #578

New Contributors

Full Changelog: v2.7.1...v2.7.2

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 21 commits:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

0 participants