Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for KaTeX rendering using markdown-it-katex #38

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

erobl
Copy link

@erobl erobl commented Nov 22, 2017

Solves issue #15 with KaTeX rendering. I figured it's lightweight enough to leave as a default option, but I can also hide it behind a flag if it's necessary.

@shime
Copy link
Owner

shime commented Nov 22, 2017

Looks good to me. Maybe we could include this - what are your thoughts, @niftylettuce?

@rcgalbo
Copy link

rcgalbo commented Feb 26, 2018

What is the status of this? Would be very useful for my markdown documents!

@erobl
Copy link
Author

erobl commented Feb 26, 2018

I've been using it for a while on my own build, and there's some bugs with the rendering. I can't find what's wrong with it.

@shime
Copy link
Owner

shime commented Feb 27, 2018

@erobl what kind of bugs? Did you report it to markdown-it-katex maintainers?

@erobl
Copy link
Author

erobl commented Feb 27, 2018

No, the main problem is that I'm not sure if I'm missing a font or a style, perhaps the style that's included in the project is conflicting with the spacing on the equations? Multiline equations aren't rendering properly:
image

The equations render fine on their demo, so it's probably my fault.

Edit:
It seems to be related with this issue. I downgraded the KaTeX CSS and it's working now. I'll be uploading the new commit soon.

@samkimhis
Copy link

The commits by @erobl work beautifully on my system (macOS, vim) for rendering equations and appear to be much faster than the MathJax workaround (instant-markdown/vim-instant-markdown#67). Could you close this pull request? I think a lot of people will benefit from this feature.

@sulibo
Copy link

sulibo commented Aug 21, 2018

It will be nice if this pull request can be merged.

@ysftaha
Copy link

ysftaha commented Sep 6, 2018

Is @shime dead?

@hcgatewood
Copy link
Contributor

Xpost from another thread: Until this gets resolved/pulled, feel free to check out my fork which includes automatic handling of KaTeX equations @hcgatewood/livedown. Installation via npm install -g git+https://github.com/hcgatewood/livedown.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants