Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding events description to readme and event/program page #180

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Jayita10
Copy link
Contributor

@Jayita10 Jayita10 commented Oct 5, 2021

Fixes #130

Type of change

Checklist:

  • My contribution follows the style guidelines of this project
  • I have performed a self-review of my own contribution
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have checked my code and corrected any misspellings

@Jayita10
Copy link
Contributor Author

Jayita10 commented Oct 5, 2021

For adding description in event page, do I need to modify eventlist.js?

@nehakalbande
Copy link
Collaborator

For adding description in event page, do I need to modify eventlist.js?

Modify eventlist.js and modify the cards in event.js

@shikha-16
Copy link
Owner

For adding description in event page, do I need to modify eventlist.js?

Yes, pull the repo, because some changes have been made and add the description in the cards

@shikha-16
Copy link
Owner

did you put the descriptions? is this ready to merge? @Jayita10

@Jayita10
Copy link
Contributor Author

did you put the descriptions? is this ready to merge? @Jayita10

Please wait for 2 more days! I am little busy with college work, Thanks!

@shikha-16
Copy link
Owner

did you put the descriptions? is this ready to merge? @Jayita10

Please wait for 2 more days! I am little busy with college work, Thanks!

okay no problem, lmk when its ready to merge!

@Jayita10
Copy link
Contributor Author

Jayita10 commented Oct 12, 2021

<Typography paragraph variant="h5" component="h2">
           {a.description}
</Typography>

Here I am thinking of using paragraph , Will it be okay?
Actually I haven't much knowledge on meterial ui and typography, so asking for conformation!

@shikha-16

@nehakalbande
Copy link
Collaborator

<Typography paragraph variant="h5" component="h2">
           {a.description}
</Typography>

Here I am thinking of using paragraph , Will it be okay? Actually I haven't much knowledge on meterial ui and typography, so asking for conformation!

@shikha-16

Hi @Jayita10 Please have a look at Material UI Components, since there components are responsive and looks good. With p tag you'll need to more css.

@shikha-16
Copy link
Owner

@Jayita10 whats the status on this?

@Jayita10
Copy link
Contributor Author

Please review @shikha-16 @nehakalbande

README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
@shikha-16
Copy link
Owner

Okay @Jayita10 can u attach a screenshot of how it looks on the website?

@shikha-16
Copy link
Owner

Okay @Jayita10 can u attach a screenshot of how it looks on the website?

@Jayita10

@shikha-16
Copy link
Owner

hi @Jayita10 can you please respond as soon as possible. thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Events Page
3 participants