New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add delete_project and bulk_delete_project #95
base: master
Are you sure you want to change the base?
Conversation
WalkthroughThe recent modifications introduce new functionalities for managing projects more efficiently in SonarQube. Specifically, these changes allow for both individual and bulk deletion of projects through newly added endpoints. Additionally, the configuration file has been updated to support these new project deletion operations alongside the existing functionalities for project component display and search. Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (2)
- sonarqube/rest/projects.py (2 hunks)
- sonarqube/utils/config.py (1 hunks)
Files skipped from review due to trivial changes (1)
- sonarqube/utils/config.py
Additional comments: 3
sonarqube/rest/projects.py (3)
- 6-7: The addition of
API_PROJECTS_BULK_DELETE_ENDPOINT
andAPI_PROJECTS_DELETE_ENDPOINT
aligns well with the existing naming conventions and is necessary for the new functionalities introduced in this PR. Good job on maintaining consistency.- 72-81: The
delete_project
function is well-implemented with clear documentation and appropriate use of the@POST
decorator. It's great to see the SonarQube version mentioned, which helps in understanding the API's evolution.- 82-102: The
bulk_delete_project
function is well-documented and uses the@POST
decorator appropriately. The parameters provide the necessary flexibility for bulk deletion operations. Ensure that the default values and types for parameters likeanalyzedBefore
,onProvisionedOnly
, andqualifiers
align with the SonarQube API's expectations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (2)
- sonarqube/rest/projects.py (2 hunks)
- sonarqube/utils/config.py (1 hunks)
Files skipped from review as they are similar to previous changes (2)
- sonarqube/rest/projects.py
- sonarqube/utils/config.py
This commit uses the code from two different PRs to add support for creating and deleting projects. Two new endpoints are added to projects.py See: shijl0925#95 shijl0925#97
Summary by CodeRabbit