Phumudzo/fix/1468 #1479
Open
Phumudzo/fix/1468 #1479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 9, 2024 11:13
added 8 commits
May 10, 2024 18:51
There was a problem hiding this comment.
removed localValue since it returning the same date as datesString which is simple to manipulate and format
I thought of retaining it for user manipulation but it eventualklly returns the same date as dateString
IvanIlyichev
requested changes
May 13, 2024
There was a problem hiding this comment.
Hi @nthangeniphumudzo. As I mentioned earlier we shouldn't convert value to string, it should be stored as moment/date object. Also I realized that the week picker doesn't work
added 7 commits
May 13, 2024 15:30
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @IvanIlyichev . Please kindly assist with this PR addressing this issue.
My Thinking process here was that the value passed to the DatePicker should always be in ISO 8601 and allow it to be formatted by the pickerFormat.
Please review and advise on this approach.