Fixed inconsistency for Discrete parameter in Bayesian optimization #110
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using a
Discrete
parameter with the range [a, b] inRandomSearch
, the values are from a (included) to b (excluded). However the same parameter used inGpyOpt
will result in values from a (included) to b (included). This PR fixed this inconsistency by modifying the behavior inGpyOpt
. It also adds a test that ensures that the produced values in a toy example are in the correct range.The steps to reproduce this issue are as follows (we also look at the values obtained with
RandomSearch
for reference):