Fully Python 2 and 3 compatibility #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- from future.utils import iteritems, since dict.iteritems() has been deprecated in 3 - NB: this requires that users install future - made print statements compatible - updated some imports ([Qq]ueue and [Cc]onfig[Pp]arser), catching the import error in python 3 that comes from using the old python 2 name - use builtins' input() instead of raw_input()
Otherwise the object's 'self' is undefined and we get a NameError
…of dict.has_key(x); prefix '.' for rel imports also ran code cleanup on utils/nlp.py
|
Also, just to make it explicit, I license my changes to the code under Apache 2, so you can just integrate it directly into the project. |
|
|
ghost
approved these changes
Jul 2, 2019
|
Thanks for catching that; I guess I was mostly interested in the NN bits of code and missed this one. |
|
No problem!! Thanks for the compatibility. Always ready to help. |
|
Does this mean that you are now in charge of maintaining and continuing development on RNNLG? I may have more PRs for you in the future if it's under active development again :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detailed lists of the changes can be found in the commit messages from 9 September 2016.
I've tested this by running the sclstm train and test as described in
README.mdin virtual environments for Python 2.7 and Python 3.5.Note that for Python 3 I needed nltk==3.2.1 instead of 3.0.0.
futurealso needs to be installed for compatibility, but otherwise the requirements are basically the same. Instead ofpip install nltk==3.0.0 theano==0.8.2users need to runpip install nltk theano==0.3.2 futureto get all of the dependencies they need. (Installing always, of course, to user space or a virtual environment.)Requirements list (incl. dependencies installed when installing
theano):