Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Re-enable ChromeOS testing #6559

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

avelad
Copy link
Collaborator

@avelad avelad commented May 8, 2024

No description provided.

@avelad avelad requested a review from joeyparrish May 8, 2024 13:49
@avelad avelad added the component: tests The issue involves our automated tests (generally; otherwise use a more specific component) label May 8, 2024
@avelad avelad added this to the v4.9 milestone May 8, 2024
@avelad avelad added the type: CI An issue with our continuous integration tests label May 8, 2024
@shaka-bot
Copy link
Collaborator

shaka-bot commented May 8, 2024

Incremental code coverage: 100.00%

@joeyparrish
Copy link
Member

I don't think our lab ChromeOS device is alive right now.

avelad added 2 commits May 9, 2024 12:02
# Conflicts:
#	.github/workflows/shaka-bot-commands/command-test.sh
@avelad
Copy link
Collaborator Author

avelad commented May 13, 2024

I don't think our lab ChromeOS device is alive right now.

Can you start it so we can adjust the tests and add it to the normal cycle? Thanks!

@joeyparrish
Copy link
Member

I will work on that later today if I can. I need to go into the lab, update the device, and check that ChromeOS WebDriver Server is still functional. We haven't used it in a long time, so it may not be any more.

When the device is on and updated, and WebDriver Server is working, I need to add it to the Shaka Lab Node config. Then it should be available to CI again.

@avelad avelad requested a review from theodab May 16, 2024 06:17
@avelad
Copy link
Collaborator Author

avelad commented May 21, 2024

@shaka-bot test

@shaka-bot
Copy link
Collaborator

@avelad: Lab tests started with arguments:

  • pr=6559

@joeyparrish
Copy link
Member

I had already updated and fixed the ChromeOS device in our lab. However, some time later, it seems to have rebooted or auto-updated and in the process, SSH was disabled.

The setup process is meant to keep SSH enabled across updates and reboots, but it's not working and needs to be fixed.

@avelad
Copy link
Collaborator Author

avelad commented May 23, 2024

I had already updated and fixed the ChromeOS device in our lab. However, some time later, it seems to have rebooted or auto-updated and in the process, SSH was disabled.

The setup process is meant to keep SSH enabled across updates and reboots, but it's not working and needs to be fixed.

Only for ChromeOS or for all the lab?

@joeyparrish
Copy link
Member

I was referring to the setup process for ChromeOS in the lab. After some more digging, I discovered that I was misremembering.

Before Generic WebDriver Server, we had a much more complicated system where we explicitly disabled auto-updates, and had to periodically run a custom tool that would check for updates, install those updates, then modify them to enable SSH and a read-write root partition before rebooting. And it failed a lot.

The docs for Generic WebDriver Server say:

Updating ChromeOS may undo the "Enabling SSH" steps above, and they may need to be repeated periodically if auto-updates are enabled on the device.

So I'm working on a solution to that. I have an idea that may work, but I haven't been able to test it yet. There's a feature in the OS now called "DLC" that may allow us to install an extra piece of software that survives updates and is reapplied after each one. If I can use that mechanism to enable SSH, and incorporate that into the setup instructions, ChromeOS WebDriver Server, which uses SSH to control the device, should continue to function across updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: tests The issue involves our automated tests (generally; otherwise use a more specific component) type: CI An issue with our continuous integration tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants