fix: set yuv full range flag to 1 for VP9 with sRGB #1398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeyparrish
approved these changes
May 10, 2024
joeyparrish
requested changes
May 10, 2024
packager/media/codecs/vp9_parser.cc
Outdated
| @@ -285,6 +285,7 @@ bool ReadBitDepthAndColorSpace(BitReader* reader, | |||
| } | |||
| } else { | |||
| // Assume 4:4:4 for colorspace SRGB. | |||
| yuv_full_range = 1; | |||
There was a problem hiding this comment.
nit: it's a bool, so yuv_full_range = true
joeyparrish
approved these changes
May 10, 2024
packager/media/codecs/vp9_parser.cc
Outdated
| @@ -285,6 +285,7 @@ bool ReadBitDepthAndColorSpace(BitReader* reader, | |||
| } | |||
| } else { | |||
| // Assume 4:4:4 for colorspace SRGB. | |||
| yuv_full_range = 1; | |||
cosmin
pushed a commit
that referenced
this pull request
May 12, 2024
🤖 I have created a release *beep* *boop* --- ## [3.2.0](v3.1.0...v3.2.0) (2024-05-11) ### Features * support Dolby Vision profile 8.x (HEVC) and 10.x (AV1) in HLS and DASH ([#1396](#1396)) ([a99cfe0](a99cfe0)) ### Bug Fixes * adaptation set IDs were referenced by lowest representation ID ([#1394](#1394)) ([94db9c9](94db9c9)), closes [#1393](#1393) * escape media URLs in MPD ([#1395](#1395)) ([98b44d0](98b44d0)) * set yuv full range flag to 1 for VP9 with sRGB ([#1398](#1398)) ([f6f60e5](f6f60e5)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If color_space is VPX_COLOR_SPACE_SRGB, the specs says that color_range should be 1 i.e. yuv_full_range = true. However, yuv_full_range is default initialized as false and isn't set in the branch for color_space is VPX_COLOR_SPACE_SRGB.
Fixes #990