-
Notifications
You must be signed in to change notification settings - Fork 491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: teletext formatting #1384
Merged
Merged
Commits on Apr 21, 2024
-
feat: parse teletext styling and formatting
Extend the teletext parser to parse the teletext styling and formatting. This includes translating rows into regions, calculating alignment from start and stop position of the text, and extracting text and background colors. The colors are limited to full lines. Both lines and regions are propagated in the TextSample structures. This is because the number of lines may differ from different sources. For teletext, there are 24 rows, but they are essentially always used with double height, so the number of output lines is 12 from 0 to 11. There are also corresponding regions are denoted "ttx_R", where R is an integer row number. A renderer can use either the line number or the region ID to render the text.
Configuration menu - View commit details
-
Copy full SHA for 6755d30 - Browse repository at this point
Copy the full SHA 6755d30View commit details -
feat: ttml generation for teletext to EBU-TT-D
Add support to render teletext input in EBU-TT-D (IMSC-1) format. This includes appropriate regions ttx_0 to ttx_11 signalled in the TextSamples, alignment and text and background colors. The general TTML output has been changed to always include metadata, layout, and styling nodes, even if they are empty. EBU-TT-D is detected by the presence of "ttx_?" regions in the samples. If detected, extra TTML elements will be added and the EBU-TT-D linePadding used as well. Appropriate styles for background and text colors are generated depending on the color and backgroundColor attributes in the text fragments.
Configuration menu - View commit details
-
Copy full SHA for 6c5e886 - Browse repository at this point
Copy the full SHA 6c5e886View commit details -
fix: adapt WebVTT output to teletext TextSample.
Teletext input generates both a region with prefix ttx_ and a floating point line number (e.g. 9.5) in the range 0 to 11.5 (due to input 0-23 as double lines). The output is adopted to drop such regions and convert the line number to an integer since the standard only used floats for percent values but not for plain line numbers.
Configuration menu - View commit details
-
Copy full SHA for 0ae6d63 - Browse repository at this point
Copy the full SHA 0ae6d63View commit details -
Configuration menu - View commit details
-
Copy full SHA for 97aaad3 - Browse repository at this point
Copy the full SHA 97aaad3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7d1aef2 - Browse repository at this point
Copy the full SHA 7d1aef2View commit details
Commits on Apr 23, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 8203178 - Browse repository at this point
Copy the full SHA 8203178View commit details
Commits on Apr 24, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 6970703 - Browse repository at this point
Copy the full SHA 6970703View commit details
Commits on Apr 25, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 4f19fa2 - Browse repository at this point
Copy the full SHA 4f19fa2View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.