New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a (currently disabled) regression test for #1341 #2524
base: main
Are you sure you want to change the base?
Conversation
We should enable this test when we fix shadow#1341
Codecov ReportBase: 67.65% // Head: 66.91% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2524 +/- ##
==========================================
- Coverage 67.65% 66.91% -0.74%
==========================================
Files 190 191 +1
Lines 28106 28178 +72
Branches 5554 5578 +24
==========================================
- Hits 19014 18856 -158
- Misses 4668 4938 +270
+ Partials 4424 4384 -40
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
let mut num_bytes_received = 0; | ||
let mut num_bytes_received_since_eagain = 0; | ||
|
||
// The socket's receive buffer should be full and we should be able to call recv() repeatedly to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe worth having a second test here where the receiver takes too long to process packets, s.t. packets do get dropped? Maybe a nanosleep after processing each packet...? I'd expect such a test to pass now, but we'd want to be careful not to make it start failing when fixing #1341.
We should enable this test when we fix #1341. Adding this test now since it was already written and it will probably be a while before we fix the issue.