CI: Update build flags for fedora 40 #984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ikerexxe
force-pushed
the
ci_fedora_flags
branch
from
aee6d6f
to
3fee5a0
Compare
There was a problem hiding this comment.
The first two commits LGTM. For the last, maybe it would be good to document in the commit message why those need to change. I assume it's just due to changes in Fedora 40, and I trust you know what you're doing. But especially after Recent Events in xz, I guess it's better to state it explicitly.
For the first two commits (the refactors):
Reviewed-by: Alejandro Colomar <alx@kernel.org>
Signed-off-by: Iker Pedrosa <ipedrosa@redhat.com> Reviewed-by: Alejandro Colomar <alx@kernel.org>
Signed-off-by: Iker Pedrosa <ipedrosa@redhat.com> Reviewed-by: Alejandro Colomar <alx@kernel.org>
ikerexxe
force-pushed
the
ci_fedora_flags
branch
from
3fee5a0
to
1d6c70a
Compare
|
Updated to tackle your last comments. |
libpam is enabled to provide `passwd` binary from this package, as there are several password quality checks that are enabled through a PAM module. Same reason to disable account-tools-setuid. sssd is disabled because `files provider` has been removed in sssd, and the underlying functionality in shadow isn't needed anymore. libcrack dependency was disabled some time ago, but the upstream repo wasn't updated. Doing it now. Signed-off-by: Iker Pedrosa <ipedrosa@redhat.com> Reviewed-by: Alejandro Colomar <alx@kernel.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that fedora 40 is out let's update the flags.