run_parts updates #707
Draft
run_parts updates #707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Similar to execution failure message.
Since stat(2) is used the result can never be a symbolic link.
Skip scripts that are either - not owned be the executing user or root, - not owned by the executing group or root, - world-writable.
Pin the script to execute before gathering its information to avoid any potential time-of-check-time-of-use issues.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| int fd = openat (dfd, namelist[n]->d_name, O_PATH | O_CLOEXEC); | ||
| if (fd == -1) { | ||
| perror ("open"); | ||
| for (; n<scanlist; n++) { |
Check notice
Code scanning / CodeQL
For loop variable changed in body Note
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use shadow_logfd instead of stdout
Similar to execution failure message.
run_part: drop void symlink check
Since stat(2) is used the result can never be a symbolic link.
skip scripts with insecure ownership/permission
Skip scripts that are either
use execveat(2) to avoid toctou issues
Pin the script to execute before gathering its information to avoid any potential time-of-check-time-of-use issues.