Add getlinex() #640
Draft
Add getlinex() #640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alejandro-colomar
force-pushed
the
getline
branch
2 times, most recently
from
b08500a
to
8d02ea8
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
alejandro-colomar
force-pushed
the
getline
branch
3 times, most recently
from
20f7e9a
to
20e683d
Compare
alejandro-colomar
force-pushed
the
getline
branch
from
20e683d
to
5532c8f
Compare
fgets(3) has a useless return value. Instead, it would be better if it returned a pointer to the terminating NUL byte. For our fgetsx(), let's write such a function. It will help implement getlinex(). getline() is a complex function, and open-coding it is error-prone. A variant that handles nicely newline escapes is even more complex. Let's write getlinex(), and use it instead of open-coding it. Signed-off-by: Alejandro Colomar <alx@kernel.org>
Signed-off-by: Alejandro Colomar <alx@kernel.org>
Signed-off-by: Alejandro Colomar <alx@kernel.org>
alejandro-colomar
force-pushed
the
getline
branch
from
5532c8f
to
c26122e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.