[discussion] Fix -- handling in su #256
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Su incorrectly tries to handle some flexible usage, including
su -c command
su -c command user
su -c command - user
su -c command -- args
su -c command user -- args
etc. But it ignored the fact that if getopt_long runs into a
--, it will leave optind at the next word. So
su -c command -- arg
tried to parse 'arg' as a user. Fix that by checking for it.
Signed-off-by: Serge Hallyn shallyn@cisco.com