New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor: I changed cursor to pointer in dropDownMenuItem for improved usability. #3596
base: main
Are you sure you want to change the base?
Conversation
@L3on06 is attempting to deploy a commit to the shadcn-pro Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this little changes important?
Absolutely! Even seemingly small changes like optimizing the cursor on a dropdown menu item can have a significant impact on user experience. By changing it to a pointer, you're providing users with a visual cue that the item is clickable, which can lead to better navigation and interaction. These attention to detail demonstrates a commitment to enhancing usability and adhering to established standards, ultimately contributing to a more polished and user-friendly interface. So yes, these changes are indeed important for improving the overall quality of the product. |
I agree with merging this since it fixes wrong UX pattern in UI kit public presentation. @ruru-m07 What would be the blocker of not merging such a straightforward improvement? |
@gurisko Thanks, Gurisko! Your support means a lot, Appreciate it! |
Same applies for components like |
@frederikmartin Sure, I'm also working on that part. I'll submit a pull request as soon as possible. |
I optimized the cursor on the dropdown menu item, changing it from the default to a pointer. This enhances the user experience and follows standard practices for improved usability.
OLD
OLD.mov
NEW
NEW.mov