New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: ApplyPrefix function in CLI not applying prefix correctly in all cases #3534

Open

danbt wants to merge 2 commits into shadcn-ui:main from danbt:danbt/fixed-apply-prefix

danbt commented Apr 19, 2024

The Issue

Have a prefix defined in components.json such as "tw-"
Install sonner component with CLI npx shadcn-ui@latest add sonner
See how className string has tw- prefix applied correctly
Notice how toast, description, actionButton, cancelButton do not have tw- prefix applied
The sonner toasts WILL NOT show in browser

The Fix

Apply prefix to property assignments, where they exist as children of an ObjectExpression
Notice how tw- prefix applied correctly


          fix: nested classNames in components like Sonner were not having pref…

156b1a4

…ix applied correctly

vercel bot commented Apr 19, 2024

@danbt is attempting to deploy a commit to the shadcn-pro Team on Vercel.

A member of the Team first needs to authorize it.


          Merge branch 'main' into danbt/fixed-apply-prefix

4ccf8f5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment