Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix select placeholder style #147

Closed
wants to merge 3 commits into from
Closed

Conversation

aboveyunhai
Copy link

@aboveyunhai aboveyunhai commented Mar 31, 2023

data-[placeholder] is the correct style for radix ui instead of placeholder, which wouldn't work in button,

@vercel
Copy link

vercel bot commented Mar 31, 2023

@aboveyunhai is attempting to deploy a commit to the shadcn-pro Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link

vercel bot commented Apr 1, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
next-template ❌ Failed (Inspect) Apr 3, 2023 5:17am
ui ❌ Failed (Inspect) Apr 3, 2023 5:17am

Copy link
Collaborator

@shadcn shadcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@Talent30
Copy link

Hi, there.

Could you resolve the failed checks and merge this fix please?

@shadcn shadcn closed this Jan 14, 2024
@necm1
Copy link

necm1 commented Feb 23, 2024

@shadcn any reasons why it's closed instead being merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants