Download ddev images during prebuild #148
Conversation
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
WalkthroughThis update introduces enhancements to the development setup by incorporating commands to download necessary images for debugging and initiating the ddev environment. These additions streamline the process, making it easier for developers to set up and debug projects efficiently. Changes
Recent Review DetailsConfiguration used: CodeRabbit UI Files selected for processing (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
| time ddev debug download-images | ||
| time ddev start |
There was a problem hiding this comment.
Consider adding error handling for the ddev commands.
It's important to ensure that the script handles potential errors gracefully. You might want to add checks to see if the commands succeed and provide appropriate error messages or recovery mechanisms if they fail. For example:
if ! time ddev debug download-images; then
echo "Failed to download ddev images."
exit 1
fi
if ! time ddev start; then
echo "Failed to start ddev."
exit 1
fi
| @@ -5,3 +5,5 @@ fi | |||
|
|
|||
| # Misc housekeeping before start | |||
| ddev config global --instrumentation-opt-in=true | |||
| time ddev debug download-images | |||
There was a problem hiding this comment.
Why do this if you're going to do a ddev start anyway?
And (not sure of context) why is the ddev start there? Is it a bogus start?
There was a problem hiding this comment.
I tried just downloading using ddev debug function. But later when I ran ddev start it decided to download more thighs that were not download previously. ddev start - ensure that I get all the images (during prebuild)
There was a problem hiding this comment.
But in that case the ddev debug download-images is not useful, true?
Also, the last time we tried this the images didn't persist anyway. I hope they're persisting now?
Note that ddev start will get the specified database type/version, whereas ddev debug download-images will get the default. In our current world, these should be the same, mariadb:10.11
Summary by CodeRabbit