Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lineagex #966

Merged
merged 4 commits into from Aug 3, 2023
Merged

Lineagex #966

merged 4 commits into from Aug 3, 2023

Conversation

zshandy
Copy link
Contributor

@zshandy zshandy commented May 30, 2023

Description

Integrate lineagex into dataprep.lineage.

How Has This Been Tested?

Tested locally in both with and without lineagex installed.

Snapshots:

Running: pytest test_lineagex

With lineagex installed:
image

Without lineagex installed:
image

Checklist:

  • My code follows the style guidelines of this project
  • I have already squashed the commits and make the commit message conform to the project standard.
  • I have already marked the commit with "BREAKING CHANGE" or "Fixes #" if needed.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@dovahcrow dovahcrow merged commit 17eda69 into develop Aug 3, 2023
2 of 11 checks passed
@dovahcrow dovahcrow deleted the lineagex branch August 3, 2023 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zshandy @dovahcrow