Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge lineagex #965

Closed
wants to merge 1 commit into from
Closed

merge lineagex #965

wants to merge 1 commit into from

Conversation

zshandy
Copy link
Contributor

@zshandy zshandy commented May 26, 2023

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Snapshots:

Include snapshots for easier review.

Checklist:

  • My code follows the style guidelines of this project
  • I have already squashed the commits and make the commit message conform to the project standard.
  • I have already marked the commit with "BREAKING CHANGE" or "Fixes #" if needed.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@codecov
Copy link

codecov bot commented May 26, 2023

Codecov Report

Patch coverage: 71.73% and project coverage change: -0.44 ⚠️

Comparison is base (26546d0) 56.37% compared to head (55d67b2) 55.93%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #965      +/-   ##
===========================================
- Coverage    56.37%   55.93%   -0.44%     
===========================================
  Files          318      314       -4     
  Lines        20630    20444     -186     
===========================================
- Hits         11630    11436     -194     
- Misses        9000     9008       +8     
Impacted Files Coverage Δ
dataprep/integrate/__init__.py 0.00% <0.00%> (ø)
dataprep/integrate/lx.py 0.00% <0.00%> (ø)
dataprep/eda/create_db_report/diagram_factory.py 95.31% <92.85%> (-0.34%) ⬇️
...rep/eda/create_db_report/db_models/table_column.py 90.69% <100.00%> (ø)
...taprep/eda/create_db_report/header/sql_metadata.py 42.01% <100.00%> (ø)
dataprep/eda/create_db_report/run_function.py 98.55% <100.00%> (+0.04%) ⬆️
dataprep/eda/create_db_report/views/orphan.py 100.00% <100.00%> (ø)

... and 10 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zshandy zshandy closed this May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant