# Feature : Setup "Fundamentals" Module #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
I don't get any chance to run the slides a'd the exercise yet, but I find this PR is a very good start to the rewrite we would like.
Few advices/questions came to me while reading :
- is there any way to merge configuration files between exercises? (. Eslintrc,.env,.browserc... )?
- some sentences in slides are too long, IMO. Remember this is just a support for our school, not a book or anything. (but it's hard to me to figure out how it seems in a large screen. )
- optional, but nice to have : reveals have a dedicated way to transform the slide into an article (with full sentences and so on) using media query. It might be great to at least have an example for future maintainers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.