Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix rspec failed tests #837

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix rspec failed tests #837

wants to merge 1 commit into from

Conversation

rusikf
Copy link
Contributor

@rusikf rusikf commented Feb 1, 2015

Hello , bootstrap fans!
When I run rspec on current master I have the following errors, so fix it changing disposition of html attributes in elements(which is not important in real practice)

twitter-bootstrap-rails$ rspec 
.............F....F...............F.................

Failures:

  1) ModalHelper returns a complete modal
     Failure/Error: expect(modal_dialog(options).gsub(/\n/, "")).to eql BASIC_MODAL.gsub(/\n/, "")

       expected: "<div class=\"bootstrap-modal modal fade\" id=\"modal\"><div class=\"modal-dialog \"><div class=\"modal-content\"><div class=\"modal-header\"><button class=\"close\" data-dismiss=\"modal\" aria-hidden=\"true\">&times;</button><h4 class=\"modal-title\">Modal header</h4></div><div class=\"modal-body\">This is the body</div><div class=\"modal-footer\"><button class=\"btn\">Save</button></div></div></div></div>"
            got: "<div id=\"modal\" class=\"bootstrap-modal modal fade\"><div class=\"modal-dialog \"><div class=\"modal-content\"><div class=\"modal-header\"><button class=\"close\" data-dismiss=\"modal\" aria-hidden=\"true\">&times;</button><h4 class=\"modal-title\">Modal header</h4></div><div class=\"modal-body\">This is the body</div><div class=\"modal-footer\"><button class=\"btn\">Save</button></div></div></div></div>"

       (compared using eql?)
     # ./spec/lib/twitter_bootstrap_rails/modal_helper_spec.rb:19:in `block (2 levels) in <top (required)>'

  2) ModalHelper renders a cancel button
     Failure/Error: expect(modal_cancel_button("Cancel", :href => "#modal", :data => {:dismiss => 'modal'}).gsub(/\n/, "")).to eql MODAL_CANCEL_BUTTON.gsub(/\n/, "")

       expected: "<a class=\"btn bootstrap-modal-cancel-button\" data-dismiss=\"modal\" href=\"#modal\">Cancel</a>"
            got: "<a class=\"btn bootstrap-modal-cancel-button\" href=\"#modal\" data-dismiss=\"modal\">Cancel</a>"

       (compared using eql?)
     # ./spec/lib/twitter_bootstrap_rails/modal_helper_spec.rb:39:in `block (2 levels) in <top (required)>'

  3) NavbarHelper menu_item should pass any other options through to the link_to method
     Failure/Error: expect(menu_item("Log out", "/users/sign_out", :class => "home_link", :method => :delete)).to eql('<li class="active"><a class="home_link" data-method="delete" href="/users/sign_out" rel="nofollow">Log out</a></li>')

       expected: "<li class=\"active\"><a class=\"home_link\" data-method=\"delete\" href=\"/users/sign_out\" rel=\"nofollow\">Log out</a></li>"
            got: "<li class=\"active\"><a class=\"home_link\" rel=\"nofollow\" data-method=\"delete\" href=\"/users/sign_out\">Log out</a></li>"

       (compared using eql?)
     # ./spec/lib/twitter_bootstrap_rails/navbar_helper_spec.rb:110:in `block (3 levels) in <top (required)>'

Finished in 0.1958 seconds (files took 1.8 seconds to load)
52 examples, 3 failures

Failed examples:

rspec ./spec/lib/twitter_bootstrap_rails/modal_helper_spec.rb:18 # ModalHelper returns a complete modal
rspec ./spec/lib/twitter_bootstrap_rails/modal_helper_spec.rb:38 # ModalHelper renders a cancel button
rspec ./spec/lib/twitter_bootstrap_rails/navbar_helper_spec.rb:108 # NavbarHelper menu_item should pass any other options through to the link_to method

@rusikf
Copy link
Contributor Author

rusikf commented Feb 1, 2015

@seyhunak , it looks really strange that travis failed in 2.1.1, but in 2.1.5 and 2.1.1 ruby rspec are completed successfully

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant