fonts: Improve font fallback #32286
Merged
fonts: Improve font fallback #32286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrobinson
added
T-linux-wpt-2013
github-actions
bot
removed
T-linux-wpt-2013
|
🔨 Triggering try run (#9094056322) for Linux WPT |
|
Test results for linux-wpt-layout-2013 from try job (#9094056322): Flaky unexpected result (15)
Stable unexpected results that are known to be intermittent (10)
Stable unexpected results (1)
|
|
Test results for linux-wpt-layout-2020 from try job (#9094056322): Flaky unexpected result (14)
Stable unexpected results that are known to be intermittent (16)
|
|
|
mrobinson
changed the title
mrobinson
added
T-linux-wpt-2013
github-actions
bot
removed
T-linux-wpt-2013
|
🔨 Triggering try run (#9140281411) for Linux WPT |
|
Test results for linux-wpt-layout-2013 from try job (#9140281411): Flaky unexpected result (13)
Stable unexpected results that are known to be intermittent (6)
|
|
Test results for linux-wpt-layout-2020 from try job (#9140281411): Flaky unexpected result (18)
Stable unexpected results that are known to be intermittent (16)
|
|
✨ Try run (#9140281411) succeeded. |
atbrakhi
approved these changes
May 27, 2024
components/gfx/font.rs
Outdated
| @@ -486,20 +486,23 @@ impl FontGroup { | |||
| pub fn find_by_codepoint<S: FontSource>( | |||
| &mut self, | |||
| font_context: &FontContext<S>, | |||
| codepoint: char, | |||
| character: char, | |||
There was a problem hiding this comment.
We have renamed codepoint to character in this PR, would it make sense to rename the function as well? maybe something find_by_character?
There was a problem hiding this comment.
Oh, great point. I've gone ahead and renamed these parameterscodepoint and next_codepoint. It may make sens to rename this function later, but for now it's probably best to keep the same name.
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
🔨 Triggering try run (#9251684875) for Android |
|
|
|
🔨 Triggering try run (#9252114336) for Android |
|
|
- Better detect situations where emoji is necessary by looking ahead one character while laying out. This allow processing Unicode presentation selectors. When detecting emoji, put emoji fonts at the front of fallback lists for all platforms. This enables monochrome emoji on Windows. Full-color emoji on Windows probably needs full support for processing the COLR table and drawing separate glyph color layers. - Improve the font fallback list on FreeType platforms. Ideally, Servo would be able to look through the entire font list to find the best font for a certain character, but until that time we can make sure the font list contains the "Noto Sans" fonts which cover most situations. Fixes servo#31664. Fixes servo#12944.
|
🔨 Triggering try run (#9252316744) for Android |
|
✨ Try run (#9252316744) succeeded. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Better detect situations where emoji is necessary by looking ahead one
character while laying out. This allow processing Unicode presentation
selectors. When detecting emoji, put emoji fonts at the front of
fallback lists for all platforms.
This enables monochrome emoji on Windows. Full-color emoji on Windows
probably needs full support for processing the COLR table and drawing
separate glyph color layers.
Improve the font fallback list on FreeType platforms. Ideally, Servo
would be able to look through the entire font list to find the best
font for a certain character, but until that time we can make sure the
font list contains the "Noto Sans" fonts which cover most situations.
Fixes #31664.
Fixes #12944.
./mach build -ddoes not report any errors./mach test-tidydoes not report any errorsdid, what font it fell back to. I have tested these changes with https://angband.pl/doc/alluni.txt
though and they significantly improve Servo's coverage on Linux. There's more work to do
for macOS and Windows though.