layout: When line-height is not normal use metrics of first font not fallback
#32165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrobinson
changed the title
Normal use metrics of first font not fallbacknormal use metrics of first font not fallback
mrobinson
force-pushed
the
fallback-font-line-height
branch
from
21ac6f9
to
cb5d2e1
Compare
mukilan
approved these changes
May 6, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
…t fallback This fixes an issue revealed by more consistent font fallback.
mrobinson
force-pushed
the
fallback-font-line-height
branch
from
cb5d2e1
to
76c0921
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue revealed by more consistent font fallback.
./mach build -ddoes not report any errors./mach test-tidydoes not report any errors