feat: add status tooltips #32011
Open
feat: add status tooltips #32011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iterminatorheart
force-pushed
the
feat/status_tooltip
branch
2 times, most recently
from
a807737
to
f8ca586
Compare
sagudev
reviewed
Apr 7, 2024
iterminatorheart
force-pushed
the
feat/status_tooltip
branch
4 times, most recently
from
140ebe8
to
35ce190
Compare
iterminatorheart
force-pushed
the
feat/status_tooltip
branch
from
35ce190
to
3a49a89
Compare
delan
requested changes
May 1, 2024
| @@ -48,6 +48,8 @@ pub struct Minibrowser { | |||
| location_dirty: Cell<bool>, | |||
|
|
|||
| load_status: LoadStatus, | |||
|
|
|||
| hovered_link: Option<String>, | |||
There was a problem hiding this comment.
recommend renaming this to status_text to make it more clearly related to EmbedderMsg::Status, and avoid confusion if we later show other kinds of status bar text
| @@ -371,6 +391,15 @@ impl Minibrowser { | |||
| need_update | |||
| } | |||
|
|
|||
| pub fn update_hovered_link( | |||
| @@ -37,6 +37,7 @@ use crate::window_trait::{WindowPortsMethods, LINE_HEIGHT}; | |||
| pub struct WebViewManager<Window: WindowPortsMethods + ?Sized> { | |||
| current_url: Option<ServoUrl>, | |||
| current_url_string: Option<String>, | |||
| hovered_link: Option<String>, | |||
| @@ -130,6 +132,10 @@ where | |||
| self.load_status | |||
| } | |||
|
|
|||
| pub fn hovered_link(&self) -> Option<String> { | |||
Comment on lines
+225
to
+227
| TopBottomPanel::bottom("innner_hover_links") | ||
| .max_height(0.0) | ||
| .show(ctx, |ui| { |
There was a problem hiding this comment.
this can be done without a TopBottomPanel by replacing ui.cursor().max.y with ctx.available_rect().max.y
| @@ -217,6 +220,23 @@ impl Minibrowser { | |||
| return; | |||
| }; | |||
| let mut embedder_events = vec![]; | |||
|
|
|||
| if self.hovered_link.is_some() { | |||
There was a problem hiding this comment.
Suggested change
| if self.hovered_link.is_some() { | |
| if let Some(status_text) = &self.status_text { |
and then do ui.label(status_text.clone());
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
./mach build -ddoes not report any errors./mach test-tidydoes not report any errors