-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
webgpu: Update wgpu to 0.19 #31995
webgpu: Update wgpu to 0.19 #31995
Conversation
Weird crash on
|
Crash is from https://bugzilla.mozilla.org/show_bug.cgi?id=1860958 Need to recheck all drop/destroy. |
This comment was marked as resolved.
This comment was marked as resolved.
Current results: https://github.com/sagudev/servo/actions/runs/8771474881/job/24069781625 a lot less crashes due to proper drops, one new crash https://gpuweb.github.io/cts/standalone/?q=webgpu:api,validation,createBindGroup:binding_resources,device_mismatch:entry={"texture":{"multisampled":false}} that is also reproducible on firefox https://crash-stats.mozilla.org/report/index/a13e187c-1065-4b5c-8a10-fee080240421 EDIT: Opened gfx-rs/wgpu#5582 |
Encoder timeouts are another example of #32008 (if poll is done on every iteration of loop everything works correctly). So I will update expectations as they are now, so we can get this moving. |
d3e07a1
to
1671378
Compare
Useful patch when you want results of wpt run: 1671378 |
Maybe we should disable the dashboard for all try runs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm OK with this short-term, but I think we need to re-design the lifecyle management of all these objects, because now there is too much back and forth over IPC and also I think we want to forbid Drop
for dom objects, and also because I think by the time something drops it's not clear if we are shutting down or if it's just that objects that is dropped.
This needs more work on the details, but I think we should do something like desribed in #32148
Instead of using 0.19, we use even newer version that removed IdentityFactories completely (also needed for #32008). I implemented proper drops for GPU* structs that are analogues to Cleanup functions in firefox.
Relevant FF commit: mozilla/gecko-dev@62af8e7
try run: https://github.com/sagudev/servo/actions/runs/8820854175/job/24217313911 (crashes on
webgpu:shader,execution,expression,*
are #31397, timeouts are due too same problem as in #32008)./mach build -d
does not report any errors./mach test-tidy
does not report any errors