servoshell: draft to show a status bar tooltip

ports/servoshell/app.rs

@@ -53,6 +53,7 @@ enum PumpResult {
     Continue {
         history_changed: bool,
         present: Present,
+        status: Option<String>,
     },
 }
 
@@ -124,7 +125,7 @@ impl App {
 
         if let Some(mut minibrowser) = app.minibrowser() {
             // Servo is not yet initialised, so there is no `servo_framebuffer_id`.
-            minibrowser.update(window.winit_window().unwrap(), None, "init");
+            minibrowser.update(window.winit_window().unwrap(), None, "init", None);
             window.set_toolbar_height(minibrowser.toolbar_height);
         }
 
@@ -221,6 +222,7 @@ impl App {
                         window.winit_window().unwrap(),
                         app.servo.as_ref().unwrap().offscreen_framebuffer_id(),
                         "RedrawRequested",
+                        None,
                     );
                     minibrowser.paint(window.winit_window().unwrap());
                 }
@@ -301,6 +303,7 @@ impl App {
                 PumpResult::Continue {
                     history_changed,
                     present,
+                    status,
                 } => {
                     if history_changed {
                         if let Some(mut minibrowser) = app.minibrowser() {
@@ -312,10 +315,21 @@ impl App {
                                     window.winit_window().unwrap(),
                                     app.servo.as_ref().unwrap().offscreen_framebuffer_id(),
                                     "update_location_in_toolbar",
+                                    None,
                                 );
                             }
                         }
                     }
+                    if let Some(inner_status) = status {
+                        if let Some(mut minibrowser) = app.minibrowser() {
+                            minibrowser.update(
+                                window.winit_window().unwrap(),
+                                app.servo.as_ref().unwrap().offscreen_framebuffer_id(),
+                                "update_status_message",
+                                Some(inner_status),
+                            );
+                        }
+                    }
                     match present {
                         Present::Immediate => {
                             // The window was resized.
@@ -330,6 +344,7 @@ impl App {
                                     window.winit_window().unwrap(),
                                     app.servo.as_ref().unwrap().offscreen_framebuffer_id(),
                                     "PumpResult::Present::Immediate",
+                                    None,
                                 );
                                 minibrowser.paint(window.winit_window().unwrap());
                             }
@@ -433,11 +448,13 @@ impl App {
         let mut need_resize = false;
         let mut need_present = false;
         let mut history_changed = false;
+        let mut status = None;
         loop {
             // Consume and handle those embedder messages.
             let servo_event_response = webviews.handle_servo_events(embedder_messages);
             need_present |= servo_event_response.need_present;
             history_changed |= servo_event_response.history_changed;
+            status = status.or(servo_event_response.status);
 
             // Route embedder events from the WebViewManager to the relevant Servo components,
             // receives and collects embedder messages from various Servo components,
@@ -469,6 +486,7 @@ impl App {
         PumpResult::Continue {
             history_changed,
             present,
+            status,
         }
     }
 

ports/servoshell/minibrowser.rs

@@ -7,7 +7,9 @@ use std::num::NonZeroU32;
 use std::sync::Arc;
 use std::time::Instant;
 
-use egui::{CentralPanel, Frame, InnerResponse, Key, Modifiers, PaintCallback, TopBottomPanel};
+use egui::{
+    CentralPanel, Frame, Id, InnerResponse, Key, Modifiers, PaintCallback, Pos2, TopBottomPanel,
+};
 use egui_glow::CallbackFn;
 use egui_winit::EventResponse;
 use euclid::{Length, Point2D, Scale};
@@ -123,6 +125,7 @@ impl Minibrowser {
         window: &winit::window::Window,
         servo_framebuffer_id: Option<gl::GLuint>,
         reason: &'static str,
+        status: Option<String>,
     ) {
         let now = Instant::now();
         trace!(
@@ -144,6 +147,18 @@ impl Minibrowser {
         let _duration = context.run(window, |ctx| {
             let InnerResponse { inner: height, .. } =
                 TopBottomPanel::top("toolbar").show(ctx, |ui| {
+                    if let Some(status_text) = &status {
+                        let suggested_position = Some(Pos2::new(0.0, ui.cursor().max.y - 20.0));
+                        let add_contents = |ui: &mut egui::Ui| {
+                            ui.label(status_text);
+                        };
+                        egui::containers::popup::show_tooltip_at(
+                            &ui.ctx(),
+                            Id::new("status_tooltip"),
+                            suggested_position,
+                            add_contents,
+                        );
+                    }
                     ui.allocate_ui_with_layout(
                         ui.available_size(),
                         egui::Layout::left_to_right(egui::Align::Center),

ports/servoshell/webview.rs

@@ -64,6 +64,7 @@ pub struct WebView {}
 pub struct ServoEventResponse {
     pub need_present: bool,
     pub history_changed: bool,
+    pub status: Option<String>,
 }
 
 impl<Window> WebViewManager<Window>
@@ -411,6 +412,7 @@ where
     ) -> ServoEventResponse {
         let mut need_present = false;
         let mut history_changed = false;
+        let mut status = None;
         for (webview_id, msg) in events {
             if let Some(webview_id) = webview_id {
                 trace_embedder_msg!(msg, "{webview_id} {msg:?}");
@@ -419,7 +421,7 @@ where
             }
             match msg {
                 EmbedderMsg::Status(_status) => {
-                    // FIXME: surface this status string in the UI somehow
+                    status = _status;
                 },
                 EmbedderMsg::ChangePageTitle(title) => {
                     self.title = title;
@@ -681,6 +683,7 @@ where
         ServoEventResponse {
             need_present,
             history_changed,
+            status,
         }
     }
 }