Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement missing ready states transition #31706

Draft
wants to merge 16 commits into
base: main
Choose a base branch
from
Draft

Implement missing ready states transition #31706

wants to merge 16 commits into from

Conversation

pylbrecht
Copy link
Sponsor Contributor

@pylbrecht pylbrecht commented Mar 15, 2024 •
edited

  • There are tests for these changes

@eerii
Copy link
Contributor

eerii commented Mar 18, 2024 •
edited

I tested the changes locally and they seem to be going in a great direction. It fixes the problem I was having in #31416 (comment) with the onloadedmetadata event firing before the metadata was loaded (and thus failing the size asserts)!

@eerii eerii mentioned this pull request Mar 18, 2024
Draft
4 tasks
@pylbrecht pylbrecht force-pushed the ready-states branch 2 times, most recently from 645a5b5 to 191d485 Compare March 21, 2024 19:59
@pylbrecht pylbrecht mentioned this pull request Apr 2, 2024
Open
@mrobinson mrobinson added T-linux-wpt-2013 Do a try run of the WPT (legacy layout) T-linux-wpt-2020 Do a try run of the WPT labels Apr 19, 2024
@github-actions github-actions bot removed T-linux-wpt-2013 Do a try run of the WPT (legacy layout) T-linux-wpt-2020 Do a try run of the WPT labels Apr 19, 2024
@github-actions GitHub Actions
Copy link

🔨 Triggering try run (#8754867367) for Linux WPT

@github-actions GitHub Actions
Copy link

Test results for linux-wpt-layout-2013 from try job (#8754867367):

Flaky unexpected result (21)
  • OK /_mozilla/css/stylesheet_media_queries.html (#17159)
    • FAIL [expected PASS] subtest: Media queries within stylesheets

      assert_equals: expected "rgb(0, 255, 0)" but got "rgb(255, 0, 0)"

  • TIMEOUT [expected OK] /_webgl/conformance/glsl/misc/shader-with-non-reserved-words.html (#16216)
    • NOTRUN [expected PASS] subtest: Overall test
  • TIMEOUT [expected OK] /_webgl/conformance/uniforms/out-of-bounds-uniform-array-access.html (#26225)
    • NOTRUN [expected PASS] subtest: Overall test
  • TIMEOUT [expected OK] /css/css-flexbox/abspos/position-absolute-013.html (#28405)
  • OK /css/css-fonts/variations/font-weight-matching.html (#20686)
    • PASS [expected FAIL] subtest: Test @font-face matching for weight 400
  • OK /css/cssom-view/MediaQueryList-extends-EventTarget.html (#25269)
    • FAIL [expected PASS] subtest: listeners for "change" type are called

      assert_equals: expected 1 but got 0

  • OK /html/browsers/browsing-the-web/navigating-across-documents/initial-empty-document/load-pageshow-events-iframe-contentWindow.html (#28681)
    • PASS [expected FAIL] subtest: load & pageshow events do not fire on contentWindow of <iframe> element created with src=''
    • PASS [expected FAIL] subtest: load & pageshow events do not fire on contentWindow of <iframe> element created with src='about:blank'
  • OK /html/browsers/browsing-the-web/navigating-across-documents/navigation-unload-same-origin-fragment.html (#20768)
    • FAIL [expected PASS] subtest: Tests that a fragment navigation in the unload handler will not block the initial navigation

      assert_equals: expected "" but got "#fragment"

  • OK /html/browsers/history/the-history-interface/traverse_the_history_3.html (#21383)
    • PASS [expected FAIL] subtest: Multiple history traversals, last would be aborted
  • TIMEOUT [expected OK] /html/browsers/history/the-history-interface/traverse_the_history_write_onload_1.html (#21581)
    • TIMEOUT [expected PASS] subtest: Traverse the history when a history entry is written in the load event

      Test timed out

  • OK [expected TIMEOUT] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_escaping-1.html (#22647)
    • FAIL [expected TIMEOUT] subtest: Check that popups from a sandboxed iframe escape the sandbox if allow-popups-to-escape-sandbox is used

      assert_equals: It came from a sandboxed iframe expected "null" but got "http://web-platform.test:8000"

  • TIMEOUT [expected CRASH] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_escaping-2.html (#22667)
    • TIMEOUT [expected FAIL] subtest: Check that popups from a sandboxed iframe escape the sandbox if allow-popups-to-escape-sandbox is used

      Test timed out

  • CRASH [expected TIMEOUT] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_nonescaping-1.html (#24066)
  • TIMEOUT [expected OK] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_nonescaping-3.html (#24066)
    • NOTRUN [expected FAIL] subtest: Check that popups from a sandboxed iframe do not escape the sandbox
  • TIMEOUT [expected OK] /html/semantics/forms/form-submission-0/reparent-form-during-planned-navigation-task.html (#29724)
    • TIMEOUT [expected PASS] subtest: reparent-form-during-planned-navigation-task

      Test timed out

  • OK /html/semantics/forms/form-submission-0/text-plain.window.html (#28687)
    • PASS [expected FAIL] subtest: text/plain: \r\n in name (formdata event)
  • OK [expected ERROR] /html/semantics/scripting-1/the-script-element/defer-script/async-script.html?reload (#29054)
  • OK /html/webappapis/dynamic-markup-insertion/document-write/module-tla-delayed.html (#29137)
    • FAIL [expected PASS] subtest: document.write in an imported module

      assert_true: onload must be called expected true got false

  • TIMEOUT [expected OK] /webstorage/localstorage-about-blank-3P-iframe-opens-3P-window.partitioned.tentative.html (#29053)
    • TIMEOUT [expected PASS] subtest: StorageKey: test 3P about:blank window opened from a 3P iframe

      Test timed out

  • OK /workers/WorkerGlobalScope-close.html (#23064)
    • PASS [expected FAIL] subtest: Test sending a message after closing.
  • OK [expected ERROR] /workers/constructors/Worker/Worker-constructor.html (#22991)
Stable unexpected results that are known to be intermittent (15)
  • TIMEOUT [expected OK] /_webgl/conformance/glsl/misc/shader-uniform-packing-restrictions.html (#28103)
    • NOTRUN [expected PASS] subtest: Overall test
  • PASS [expected FAIL] /css/css-sizing/dynamic-available-size-iframe.html (#31559)
  • TIMEOUT /fetch/metadata/generated/css-images.sub.tentative.html (#29047)
    • TIMEOUT [expected PASS] subtest: background-image sec-fetch-site - HTTPS downgrade (header not sent)

      Test timed out

  • OK /html/browsers/browsing-the-web/navigating-across-documents/empty-iframe-load-event.html (#29066)
    • FAIL [expected PASS] subtest: Check execution order from nested timeout

      assert_equals: Expected nested setTimeout to run second expected true but got false

    • FAIL [expected PASS] subtest: Check execution order on load handler

      assert_equals: Expected onload to run first expected false but got true

  • OK /html/browsers/browsing-the-web/navigating-across-documents/navigation-unload-same-origin.window.html (#29049)
    • PASS [expected FAIL] subtest: Same-origin navigation started from unload handler must be ignored
  • PASS [expected CRASH] /html/canvas/element/manual/drawing-text-to-the-canvas/canvas.2d.disconnected-font-size-math.html (#30063)
  • FAIL [expected CRASH] /html/canvas/element/manual/text/canvas.2d.disconnected.html (#30063)
  • OK [expected TIMEOUT] /html/infrastructure/urls/base-url/document-base-url-window-initiator-is-not-opener.https.window.html (#30970)
  • OK [expected TIMEOUT] /html/interaction/focus/the-autofocus-attribute/supported-elements.html (#24145)
  • TIMEOUT [expected OK] /html/semantics/embedded-content/media-elements/track/track-element/no-cuechange-before-play.html (#31014)
    • TIMEOUT [expected FAIL] subtest: Ensure that the 'cuechange' event is not fired before video playback has begun.

      Test timed out

  • TIMEOUT [expected OK] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_escaping-3.html (#24057)
    • TIMEOUT [expected FAIL] subtest: Check that popups from a sandboxed iframe escape the sandbox if allow-popups-to-escape-sandbox is used

      Test timed out

  • OK [expected TIMEOUT] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_nonescaping-2.html (#22154)
    • FAIL [expected NOTRUN] subtest: Check that popups from a sandboxed iframe do not escape the sandbox

      assert_equals: It came from a sandboxed iframe expected "null" but got "http://web-platform.test:8000"

  • OK [expected TIMEOUT] /webmessaging/with-ports/017.html (#24486)
    • PASS [expected TIMEOUT] subtest: origin of the script that invoked the method, about:blank
  • TIMEOUT [expected OK] /webmessaging/with-ports/018.html (#24485)
    • TIMEOUT [expected PASS] subtest: origin of the script that invoked the method, javascript:

      Test timed out

  • OK [expected TIMEOUT] /webmessaging/without-ports/018.html (#24485)
    • PASS [expected TIMEOUT] subtest: origin of the script that invoked the method, javascript:
Stable unexpected results (12)
  • TIMEOUT [expected OK] /css/selectors/media/media-playback-state.html
    • TIMEOUT [expected FAIL] subtest: Test :paused pseudo-classes

      Test timed out

    • NOTRUN [expected FAIL] subtest: Test :seeking pseudo-class
  • OK /fetch/range/non-matching-range-response.html
    • FAIL [expected PASS] subtest: Range response out of range of request should succeed

      assert_equals: expected "ok" but got "timeout"

  • TIMEOUT /html/canvas/element/manual/imagebitmap/createImageBitmap-drawImage.html
    • TIMEOUT [expected FAIL] subtest: createImageBitmap from an HTMLVideoElement, and drawImage on the created ImageBitmap

      Test timed out

    • NOTRUN [expected FAIL] subtest: createImageBitmap from an HTMLVideoElement scaled down, and drawImage on the created ImageBitmap
    • NOTRUN [expected FAIL] subtest: createImageBitmap from an HTMLVideoElement scaled up, and drawImage on the created ImageBitmap
    • NOTRUN [expected FAIL] subtest: createImageBitmap from an HTMLVideoElement resized, and drawImage on the created ImageBitmap
    • NOTRUN [expected FAIL] subtest: createImageBitmap from an HTMLVideoElement with negative sw/sh, and drawImage on the created ImageBitmap
    • NOTRUN [expected FAIL] subtest: createImageBitmap from an HTMLVideoElement from a data URL, and drawImage on the created ImageBitmap
    • NOTRUN [expected FAIL] subtest: createImageBitmap from an HTMLVideoElement from a data URL scaled down, and drawImage on the created ImageBitmap
    • NOTRUN [expected FAIL] subtest: createImageBitmap from an HTMLVideoElement from a data URL scaled up, and drawImage on the created ImageBitmap
    • NOTRUN [expected FAIL] subtest: createImageBitmap from an HTMLVideoElement from a data URL resized, and drawImage on the created ImageBitmap
    • NOTRUN [expected FAIL] subtest: createImageBitmap from an HTMLVideoElement from a data URL with negative sw/sh, and drawImage on the created ImageBitmap
    • And 11 more unexpected results...
  • TIMEOUT /html/canvas/element/manual/imagebitmap/createImageBitmap-flipY.html
    • TIMEOUT [expected FAIL] subtest: createImageBitmap from an HTMLVideoElement imageOrientation: "from-image", and drawImage on the created ImageBitmap

      Test timed out

    • NOTRUN [expected FAIL] subtest: createImageBitmap from an HTMLVideoElement imageOrientation: "flipY", and drawImage on the created ImageBitmap
    • NOTRUN [expected FAIL] subtest: createImageBitmap from an HTMLVideoElement from a data URL imageOrientation: "from-image", and drawImage on the created ImageBitmap
    • NOTRUN [expected FAIL] subtest: createImageBitmap from an HTMLVideoElement from a data URL imageOrientation: "flipY", and drawImage on the created ImageBitmap
    • NOTRUN [expected FAIL] subtest: createImageBitmap from a bitmap HTMLImageElement imageOrientation: "from-image", and drawImage on the created ImageBitmap
    • NOTRUN [expected FAIL] subtest: createImageBitmap from a bitmap HTMLImageElement imageOrientation: "flipY", and drawImage on the created ImageBitmap
    • NOTRUN [expected FAIL] subtest: createImageBitmap from a vector HTMLImageElement imageOrientation: "from-image", and drawImage on the created ImageBitmap
    • NOTRUN [expected FAIL] subtest: createImageBitmap from a vector HTMLImageElement imageOrientation: "flipY", and drawImage on the created ImageBitmap
    • NOTRUN [expected TIMEOUT] subtest: createImageBitmap from a bitmap SVGImageElement imageOrientation: "from-image", and drawImage on the created ImageBitmap
  • TIMEOUT /html/canvas/element/manual/imagebitmap/createImageBitmap-invalid-args.html
    • TIMEOUT [expected FAIL] subtest: createImageBitmap with an HTMLVideoElement source and sw set to 0

      Test timed out

    • NOTRUN [expected FAIL] subtest: createImageBitmap with an HTMLVideoElement source and sh set to 0
    • NOTRUN [expected FAIL] subtest: createImageBitmap with an HTMLVideoElement source and oversized (unallocatable) crop region
    • NOTRUN [expected FAIL] subtest: createImageBitmap with an HTMLVideoElement source and a value of 0 int resizeWidth
    • NOTRUN [expected FAIL] subtest: createImageBitmap with an HTMLVideoElement source and a value of 0 in resizeHeight
    • NOTRUN [expected FAIL] subtest: createImageBitmap with an HTMLVideoElement source and a value between 0 and 1 in resizeWidth
    • NOTRUN [expected FAIL] subtest: createImageBitmap with an HTMLVideoElement source and a value between 0 and 1 in resizeHeight
    • NOTRUN [expected FAIL] subtest: createImageBitmap with an HTMLVideoElement from a data URL source and sw set to 0
    • NOTRUN [expected FAIL] subtest: createImageBitmap with an HTMLVideoElement from a data URL source and sh set to 0
    • NOTRUN [expected FAIL] subtest: createImageBitmap with an HTMLVideoElement from a data URL source and oversized (unallocatable) crop region
    • And 19 more unexpected results...
  • TIMEOUT /html/canvas/element/manual/imagebitmap/createImageBitmap-serializable.html
    • TIMEOUT [expected FAIL] subtest: Serialize ImageBitmap created from an HTMLVideoElement

      Test timed out

    • NOTRUN [expected FAIL] subtest: Serialize ImageBitmap created from an HTMLVideoElement from a data URL
    • NOTRUN [expected FAIL] subtest: Serialize ImageBitmap created from a bitmap HTMLImageElement
    • NOTRUN [expected FAIL] subtest: Serialize ImageBitmap created from a vector HTMLImageElement
    • NOTRUN [expected TIMEOUT] subtest: Serialize ImageBitmap created from a bitmap SVGImageElement
  • TIMEOUT /html/canvas/element/manual/imagebitmap/createImageBitmap-transfer.html
    • TIMEOUT [expected FAIL] subtest: Transfer ImageBitmap created from an HTMLVideoElement

      Test timed out

    • NOTRUN [expected FAIL] subtest: Transfer ImageBitmap created from an HTMLVideoElement from a data URL
    • NOTRUN [expected FAIL] subtest: Transfer ImageBitmap created from a bitmap HTMLImageElement
    • NOTRUN [expected FAIL] subtest: Transfer ImageBitmap created from a vector HTMLImageElement
    • NOTRUN [expected TIMEOUT] subtest: Transfer ImageBitmap created from a bitmap SVGImageElement
  • TIMEOUT [expected OK] /html/canvas/element/manual/wide-gamut-canvas/canvas-display-p3-drawImage-ImageBitmap-video.html
    • TIMEOUT [expected FAIL] subtest: sRGB-FF0100, Context srgb, ImageData srgb, cropSource=false

      Test timed out

    • NOTRUN [expected FAIL] subtest: sRGB-FF0100, Context srgb, ImageData srgb, cropSource=true
    • NOTRUN [expected FAIL] subtest: sRGB-FF0100, Context srgb, ImageData display-p3, cropSource=false
    • NOTRUN [expected FAIL] subtest: sRGB-FF0100, Context srgb, ImageData display-p3, cropSource=true
    • NOTRUN [expected FAIL] subtest: sRGB-FF0100, Context display-p3, ImageData srgb, cropSource=false
    • NOTRUN [expected FAIL] subtest: sRGB-FF0100, Context display-p3, ImageData srgb, cropSource=true
    • NOTRUN [expected FAIL] subtest: sRGB-FF0100, Context display-p3, ImageData display-p3, cropSource=false
    • NOTRUN [expected FAIL] subtest: sRGB-FF0100, Context display-p3, ImageData display-p3, cropSource=true
    • NOTRUN [expected FAIL] subtest: sRGB-BB0000, Context srgb, ImageData srgb, cropSource=false
    • NOTRUN [expected FAIL] subtest: sRGB-BB0000, Context srgb, ImageData srgb, cropSource=true
    • And 22 more unexpected results...
  • TIMEOUT [expected OK] /html/canvas/element/manual/wide-gamut-canvas/canvas-display-p3-drawImage-video.html
    • TIMEOUT [expected FAIL] subtest: sRGB-FF0100, Context srgb, ImageData srgb, scaleImage=false

      Test timed out

    • NOTRUN [expected FAIL] subtest: sRGB-FF0100, Context srgb, ImageData srgb, scaleImage=true
    • NOTRUN [expected FAIL] subtest: sRGB-FF0100, Context srgb, ImageData display-p3, scaleImage=false
    • NOTRUN [expected FAIL] subtest: sRGB-FF0100, Context srgb, ImageData display-p3, scaleImage=true
    • NOTRUN [expected FAIL] subtest: sRGB-FF0100, Context display-p3, ImageData srgb, scaleImage=false
    • NOTRUN [expected FAIL] subtest: sRGB-FF0100, Context display-p3, ImageData srgb, scaleImage=true
    • NOTRUN [expected FAIL] subtest: sRGB-FF0100, Context display-p3, ImageData display-p3, scaleImage=false
    • NOTRUN [expected FAIL] subtest: sRGB-FF0100, Context display-p3, ImageData display-p3, scaleImage=true
    • NOTRUN [expected FAIL] subtest: sRGB-BB0000, Context srgb, ImageData srgb, scaleImage=false
    • NOTRUN [expected FAIL] subtest: sRGB-BB0000, Context srgb, ImageData srgb, scaleImage=true
    • And 22 more unexpected results...
  • OK /html/semantics/embedded-content/media-elements/audio_loop_seek_to_eos.html
    • PASS [expected FAIL] subtest: seeking to the end of looping audio
  • TIMEOUT [expected OK] /html/semantics/embedded-content/media-elements/track/track-element/track-cue-mutable-fragment.html
    • TIMEOUT [expected FAIL] subtest: Cue fragment is mutable

      Test timed out

  • TIMEOUT [expected OK] /html/semantics/embedded-content/media-elements/track/track-element/track-mode-not-changed-by-new-track.html
    • TIMEOUT [expected FAIL] subtest: A track appended after the initial track configuration does not change other tracks

      Test timed out

@github-actions GitHub Actions
Copy link

Test results for linux-wpt-layout-2020 from try job (#8754867367):

Flaky unexpected result (23)
  • TIMEOUT /FileAPI/url/url-in-tags-revoke.window.html (#19978)
    • TIMEOUT [expected FAIL] subtest: Opening a blob URL in a new window immediately before revoking it works.

      Test timed out

  • FAIL [expected PASS] /_mozilla/css/dirty_viewport.html (#13731)
  • TIMEOUT [expected OK] /_webgl/conformance/glsl/misc/shader-with-non-reserved-words.html (#16216)
    • NOTRUN [expected PASS] subtest: Overall test
  • TIMEOUT [expected OK] /_webgl/conformance/uniforms/out-of-bounds-uniform-array-access.html (#26225)
    • NOTRUN [expected PASS] subtest: Overall test
  • PASS [expected FAIL] /css/css-sizing/dynamic-available-size-iframe.html (#31559)
  • TIMEOUT /fetch/metadata/generated/css-images.sub.tentative.html (#29047)
    • PASS [expected TIMEOUT] subtest: background-image sec-fetch-site - HTTPS downgrade (header not sent)
  • OK /html/browsers/browsing-the-web/navigating-across-documents/initial-empty-document/iframe-src-aboutblank-navigate-immediately.html (#29048)
    • PASS [expected FAIL] subtest: Navigating to a different document with link click
  • OK /html/browsers/browsing-the-web/navigating-across-documents/initial-empty-document/load-pageshow-events-iframe-contentWindow.html (#28681)
    • FAIL [expected PASS] subtest: load & pageshow events do not fire on contentWindow of <iframe> element created with src=''

      assert_unreached: load should not be fired Reached unreachable code

  • OK /html/browsers/browsing-the-web/navigating-across-documents/javascript-url-return-value-handling-dynamic.html (#28066)
    • FAIL [expected PASS] subtest: 0041 set in href="" targeting a frame and clicked

      assert_equals: expected "A" but got ""

    • FAIL [expected PASS] subtest: 0080 00FF set in href="" targeting a frame and clicked

      assert_equals: expected "�ÿ" but got ""

    • FAIL [expected PASS] subtest: 0080 00FF 0100 set in href="" targeting a frame and clicked

      assert_equals: expected "�ÿĀ" but got ""

    • FAIL [expected PASS] subtest: D83D DE0D set in href="" targeting a frame and clicked

      assert_equals: expected "😍" but got ""

    • FAIL [expected PASS] subtest: DE0D 0041 set in href="" targeting a frame and clicked

      assert_equals: expected "\ufffdA" but got ""

  • OK /html/browsers/browsing-the-web/navigating-across-documents/navigation-unload-cross-origin.sub.window.html (#29056)
    • FAIL [expected PASS] subtest: Cross-origin navigation started from unload handler must be ignored

      promise_test: Unhandled rejection with value: object "SecurityError: The operation is insecure."

  • OK /html/browsers/history/the-history-interface/traverse_the_history_2.html (#21383)
    • PASS [expected FAIL] subtest: Multiple history traversals, last would be aborted
  • OK /html/browsers/history/the-history-interface/traverse_the_history_5.html (#21383)
    • FAIL [expected PASS] subtest: Multiple history traversals, last would be aborted

      assert_array_equals: Pages opened during history navigation expected property 1 to be 5 but got 3 (expected array [6, 5] got [6, 3])

  • OK [expected TIMEOUT] /html/infrastructure/urls/base-url/document-base-url-window-initiator-is-not-opener.https.window.html (#30970)
  • TIMEOUT [expected OK] /html/interaction/focus/the-autofocus-attribute/supported-elements.html (#24145)
    • TIMEOUT [expected PASS] subtest: Non-HTMLElement should not support autofocus

      Test timed out

    • NOTRUN [expected FAIL] subtest: Host element with delegatesFocus should support autofocus
    • NOTRUN [expected FAIL] subtest: Host element with delegatesFocus including no focusable descendants should be skipped
    • NOTRUN [expected FAIL] subtest: Area element should support autofocus
  • OK [expected TIMEOUT] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_escaping-3.html (#24057)
    • FAIL [expected TIMEOUT] subtest: Check that popups from a sandboxed iframe escape the sandbox if allow-popups-to-escape-sandbox is used

      assert_equals: It came from a sandboxed iframe expected "null" but got "http://web-platform.test:8000"

  • OK /html/semantics/links/links-created-by-a-and-area-elements/htmlanchorelement_noopener.html (#23205)
    • PASS [expected FAIL] subtest: Check that rel=noopener with target=_self does a normal load
  • OK [expected ERROR] /html/semantics/scripting-1/the-script-element/defer-script/async-script.html?reload (#29054)
  • OK /html/webappapis/dynamic-markup-insertion/document-write/module-tla-delayed.html (#29137)
    • FAIL [expected PASS] subtest: document.write in an imported module

      assert_true: onload must be called expected true got false

  • TIMEOUT [expected OK] /html/webappapis/scripting/processing-model-2/integration-with-the-javascript-job-queue/promise-job-entry-different-function-realm.html (#25805)
    • TIMEOUT [expected FAIL] subtest: Fulfillment handler on pending-then-fulfilled promise

      Test timed out

  • TIMEOUT [expected OK] /resource-timing/nested-context-navigations-iframe.html (#24311)
    • TIMEOUT [expected PASS] subtest: Test that iframe navigations are not observable by the parent, even after history navigations by the parent

      Test timed out

    • NOTRUN [expected PASS] subtest: Test that crossorigin iframe navigations are not observable by the parent, even after history navigations by the parent
    • NOTRUN [expected PASS] subtest: Test that cross-site iframe navigations are not observable by the parent, even after history navigations by the parent
    • NOTRUN [expected PASS] subtest: Test that iframe navigations are not observable by the parent
    • NOTRUN [expected PASS] subtest: Test that crossorigin iframe navigations are not observable by the parent
    • NOTRUN [expected PASS] subtest: Test that cross-site iframe navigations are not observable by the parent
    • NOTRUN [expected PASS] subtest: Test that iframe refreshes are not observable by the parent
    • NOTRUN [expected PASS] subtest: Test that crossorigin iframe refreshes are not observable by the parent
    • NOTRUN [expected PASS] subtest: Test that cross-site iframe refreshes are not observable by the parent
  • OK [expected TIMEOUT] /webmessaging/with-ports/017.html (#24486)
    • PASS [expected TIMEOUT] subtest: origin of the script that invoked the method, about:blank
  • OK [expected ERROR] /workers/constructors/Worker/Worker-constructor.html (#22991)
  • OK /xhr/open-url-multi-window-5.htm (#23360)
    • FAIL [expected PASS] subtest: XMLHttpRequest: open() resolving URLs (multi-Window; 5)

      assert_throws_dom: function "function() {client.open("GET", "...") }" did not throw

Stable unexpected results that are known to be intermittent (19)
  • TIMEOUT [expected OK] /_webgl/conformance/glsl/misc/shader-uniform-packing-restrictions.html (#28103)
    • NOTRUN [expected PASS] subtest: Overall test
  • OK /css/css-fonts/variations/at-font-face-font-matching.html (#20684)
    • PASS [expected FAIL] subtest: Matching font-weight: '399' should prefer '350 399' over '340 360'
    • PASS [expected FAIL] subtest: Matching font-style: 'oblique 10deg' should prefer 'oblique 5deg' over 'oblique 15deg 20deg'
    • PASS [expected FAIL] subtest: Matching font-style: 'oblique -20deg' should prefer 'oblique -60deg -40deg' over 'oblique -10deg'
  • OK /css/cssom-view/MediaQueryList-addListener-removeListener.html (#24569)
    • PASS [expected FAIL] subtest: listeners are called correct number of times
  • OK /html/browsers/browsing-the-web/navigating-across-documents/initial-empty-document/load-pageshow-events-window-open.html (#28691)
    • FAIL [expected PASS] subtest: load event does not fire on window.open('about:blank')

      assert_unreached: load should not be fired Reached unreachable code

  • OK /html/browsers/browsing-the-web/navigating-across-documents/replace-before-load/a-click.html (#28697)
    • PASS [expected FAIL] subtest: aElement.click() before the load event must NOT replace
  • PASS [expected CRASH] /html/canvas/element/manual/drawing-text-to-the-canvas/canvas.2d.disconnected-font-size-math.html (#30063)
  • FAIL [expected CRASH] /html/canvas/element/manual/text/canvas.2d.disconnected.html (#30063)
  • TIMEOUT [expected OK] /html/semantics/embedded-content/media-elements/track/track-element/no-cuechange-before-play.html (#31014)
    • TIMEOUT [expected FAIL] subtest: Ensure that the 'cuechange' event is not fired before video playback has begun.

      Test timed out

  • TIMEOUT [expected CRASH] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_escaping-1.html (#22647)
  • TIMEOUT [expected CRASH] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_escaping-2.html (#22667)
  • TIMEOUT [expected CRASH] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_nonescaping-1.html (#24066)
  • TIMEOUT [expected OK] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_nonescaping-3.html (#24066)
  • TIMEOUT [expected OK] /html/semantics/embedded-content/the-iframe-element/sandbox-top-navigation-cross-site.tentative.sub.window.html (#31754)
    • TIMEOUT [expected FAIL] subtest: A cross-site unsandboxed iframe navigation consumes user activation and disallows top-level navigation.

      Test timed out

    • NOTRUN [expected FAIL] subtest: A same-site unsandboxed iframe navigation does not consume user activation and allows top-level navigation.
    • NOTRUN [expected FAIL] subtest: A same-site unsandboxed iframe navigation without sticky user activation does not allow top-level navigation.
  • OK [expected TIMEOUT] /html/semantics/forms/form-submission-0/reparent-form-during-planned-navigation-task.html (#29724)
    • PASS [expected TIMEOUT] subtest: reparent-form-during-planned-navigation-task
  • OK [expected CRASH] /html/semantics/forms/the-fieldset-element/disabled-003.html (#31730)
  • OK /html/webappapis/dynamic-markup-insertion/document-write/module-static-import-delayed.html (#26243)
    • FAIL [expected PASS] subtest: document.write in an imported module

      assert_true: onload must be called expected true got false

  • TIMEOUT /resource-timing/test_resource_timing.https.html (#25216)
    • PASS [expected FAIL] subtest: PerformanceEntry has correct name, initiatorType, startTime, and duration (img)
  • OK [expected TIMEOUT] /webmessaging/with-ports/018.html (#24485)
    • PASS [expected TIMEOUT] subtest: origin of the script that invoked the method, javascript:
  • OK [expected TIMEOUT] /webmessaging/without-ports/017.html (#24486)
    • PASS [expected TIMEOUT] subtest: origin of the script that invoked the method, about:blank
Stable unexpected results (10)
  • TIMEOUT [expected OK] /css/selectors/media/media-playback-state.html
    • TIMEOUT [expected FAIL] subtest: Test :paused pseudo-classes

      Test timed out

    • NOTRUN [expected FAIL] subtest: Test :seeking pseudo-class
  • OK /fetch/range/non-matching-range-response.html
    • FAIL [expected PASS] subtest: Range response out of range of request should succeed

      assert_equals: expected "ok" but got "timeout"

  • TIMEOUT /html/canvas/element/manual/imagebitmap/createImageBitmap-drawImage.html
    • TIMEOUT [expected FAIL] subtest: createImageBitmap from an HTMLVideoElement, and drawImage on the created ImageBitmap

      Test timed out

    • NOTRUN [expected FAIL] subtest: createImageBitmap from an HTMLVideoElement scaled down, and drawImage on the created ImageBitmap
    • NOTRUN [expected FAIL] subtest: createImageBitmap from an HTMLVideoElement scaled up, and drawImage on the created ImageBitmap
    • NOTRUN [expected FAIL] subtest: createImageBitmap from an HTMLVideoElement resized, and drawImage on the created ImageBitmap
    • NOTRUN [expected FAIL] subtest: createImageBitmap from an HTMLVideoElement with negative sw/sh, and drawImage on the created ImageBitmap
    • NOTRUN [expected FAIL] subtest: createImageBitmap from an HTMLVideoElement from a data URL, and drawImage on the created ImageBitmap
    • NOTRUN [expected FAIL] subtest: createImageBitmap from an HTMLVideoElement from a data URL scaled down, and drawImage on the created ImageBitmap
    • NOTRUN [expected FAIL] subtest: createImageBitmap from an HTMLVideoElement from a data URL scaled up, and drawImage on the created ImageBitmap
    • NOTRUN [expected FAIL] subtest: createImageBitmap from an HTMLVideoElement from a data URL resized, and drawImage on the created ImageBitmap
    • NOTRUN [expected FAIL] subtest: createImageBitmap from an HTMLVideoElement from a data URL with negative sw/sh, and drawImage on the created ImageBitmap
    • And 11 more unexpected results...
  • TIMEOUT /html/canvas/element/manual/imagebitmap/createImageBitmap-flipY.html
    • TIMEOUT [expected FAIL] subtest: createImageBitmap from an HTMLVideoElement imageOrientation: "from-image", and drawImage on the created ImageBitmap

      Test timed out

    • NOTRUN [expected FAIL] subtest: createImageBitmap from an HTMLVideoElement imageOrientation: "flipY", and drawImage on the created ImageBitmap
    • NOTRUN [expected FAIL] subtest: createImageBitmap from an HTMLVideoElement from a data URL imageOrientation: "from-image", and drawImage on the created ImageBitmap
    • NOTRUN [expected FAIL] subtest: createImageBitmap from an HTMLVideoElement from a data URL imageOrientation: "flipY", and drawImage on the created ImageBitmap
    • NOTRUN [expected FAIL] subtest: createImageBitmap from a bitmap HTMLImageElement imageOrientation: "from-image", and drawImage on the created ImageBitmap
    • NOTRUN [expected FAIL] subtest: createImageBitmap from a bitmap HTMLImageElement imageOrientation: "flipY", and drawImage on the created ImageBitmap
    • NOTRUN [expected FAIL] subtest: createImageBitmap from a vector HTMLImageElement imageOrientation: "from-image", and drawImage on the created ImageBitmap
    • NOTRUN [expected FAIL] subtest: createImageBitmap from a vector HTMLImageElement imageOrientation: "flipY", and drawImage on the created ImageBitmap
    • NOTRUN [expected TIMEOUT] subtest: createImageBitmap from a bitmap SVGImageElement imageOrientation: "from-image", and drawImage on the created ImageBitmap
  • TIMEOUT /html/canvas/element/manual/imagebitmap/createImageBitmap-invalid-args.html
    • TIMEOUT [expected FAIL] subtest: createImageBitmap with an HTMLVideoElement source and sw set to 0

      Test timed out

    • NOTRUN [expected FAIL] subtest: createImageBitmap with an HTMLVideoElement source and sh set to 0
    • NOTRUN [expected FAIL] subtest: createImageBitmap with an HTMLVideoElement source and oversized (unallocatable) crop region
    • NOTRUN [expected FAIL] subtest: createImageBitmap with an HTMLVideoElement source and a value of 0 int resizeWidth
    • NOTRUN [expected FAIL] subtest: createImageBitmap with an HTMLVideoElement source and a value of 0 in resizeHeight
    • NOTRUN [expected FAIL] subtest: createImageBitmap with an HTMLVideoElement source and a value between 0 and 1 in resizeWidth
    • NOTRUN [expected FAIL] subtest: createImageBitmap with an HTMLVideoElement source and a value between 0 and 1 in resizeHeight
    • NOTRUN [expected FAIL] subtest: createImageBitmap with an HTMLVideoElement from a data URL source and sw set to 0
    • NOTRUN [expected FAIL] subtest: createImageBitmap with an HTMLVideoElement from a data URL source and sh set to 0
    • NOTRUN [expected FAIL] subtest: createImageBitmap with an HTMLVideoElement from a data URL source and oversized (unallocatable) crop region
    • And 19 more unexpected results...
  • TIMEOUT [expected OK] /html/canvas/element/manual/wide-gamut-canvas/canvas-display-p3-drawImage-ImageBitmap-video.html
    • TIMEOUT [expected FAIL] subtest: sRGB-FF0100, Context srgb, ImageData srgb, cropSource=false

      Test timed out

    • NOTRUN [expected FAIL] subtest: sRGB-FF0100, Context srgb, ImageData srgb, cropSource=true
    • NOTRUN [expected FAIL] subtest: sRGB-FF0100, Context srgb, ImageData display-p3, cropSource=false
    • NOTRUN [expected FAIL] subtest: sRGB-FF0100, Context srgb, ImageData display-p3, cropSource=true
    • NOTRUN [expected FAIL] subtest: sRGB-FF0100, Context display-p3, ImageData srgb, cropSource=false
    • NOTRUN [expected FAIL] subtest: sRGB-FF0100, Context display-p3, ImageData srgb, cropSource=true
    • NOTRUN [expected FAIL] subtest: sRGB-FF0100, Context display-p3, ImageData display-p3, cropSource=false
    • NOTRUN [expected FAIL] subtest: sRGB-FF0100, Context display-p3, ImageData display-p3, cropSource=true
    • NOTRUN [expected FAIL] subtest: sRGB-BB0000, Context srgb, ImageData srgb, cropSource=false
    • NOTRUN [expected FAIL] subtest: sRGB-BB0000, Context srgb, ImageData srgb, cropSource=true
    • And 22 more unexpected results...
  • TIMEOUT [expected OK] /html/canvas/element/manual/wide-gamut-canvas/canvas-display-p3-drawImage-video.html
    • TIMEOUT [expected FAIL] subtest: sRGB-FF0100, Context srgb, ImageData srgb, scaleImage=false

      Test timed out

    • NOTRUN [expected FAIL] subtest: sRGB-FF0100, Context srgb, ImageData srgb, scaleImage=true
    • NOTRUN [expected FAIL] subtest: sRGB-FF0100, Context srgb, ImageData display-p3, scaleImage=false
    • NOTRUN [expected FAIL] subtest: sRGB-FF0100, Context srgb, ImageData display-p3, scaleImage=true
    • NOTRUN [expected FAIL] subtest: sRGB-FF0100, Context display-p3, ImageData srgb, scaleImage=false
    • NOTRUN [expected FAIL] subtest: sRGB-FF0100, Context display-p3, ImageData srgb, scaleImage=true
    • NOTRUN [expected FAIL] subtest: sRGB-FF0100, Context display-p3, ImageData display-p3, scaleImage=false
    • NOTRUN [expected FAIL] subtest: sRGB-FF0100, Context display-p3, ImageData display-p3, scaleImage=true
    • NOTRUN [expected FAIL] subtest: sRGB-BB0000, Context srgb, ImageData srgb, scaleImage=false
    • NOTRUN [expected FAIL] subtest: sRGB-BB0000, Context srgb, ImageData srgb, scaleImage=true
    • And 22 more unexpected results...
  • OK /html/semantics/embedded-content/media-elements/audio_loop_seek_to_eos.html
    • PASS [expected FAIL] subtest: seeking to the end of looping audio
  • TIMEOUT [expected OK] /html/semantics/embedded-content/media-elements/track/track-element/track-cue-mutable-fragment.html
    • TIMEOUT [expected FAIL] subtest: Cue fragment is mutable

      Test timed out

  • TIMEOUT [expected OK] /html/semantics/embedded-content/media-elements/track/track-element/track-mode-not-changed-by-new-track.html
    • TIMEOUT [expected FAIL] subtest: A track appended after the initial track configuration does not change other tracks

      Test timed out

@github-actions GitHub Actions
Copy link

⚠️ Try run (#8754867367) failed.

@pylbrecht
Add debug! logs
6add202
@pylbrecht
Expect video_size_preserved_after_ended.html to pass
ce7e165
@pylbrecht
Don't change ready state in HTMLMediaElementFetchListener
86da415
@pylbrecht
Add VideoTrackList::remove()
2fdbbf2 
Implementation is still pretty crude (panics if `idx` is out of bounds).
It's good enough for prototyping though. I will improve it once I get
things working.
@pylbrecht
Remove video track when playback ended
4a0d669
@pylbrecht
Add AudioTrackList::remove()
a555d60
@pylbrecht
Remove audio track when playback ended
58c2e67
@pylbrecht
Fire removetrack event for video track
0671c82
@pylbrecht
Fire removetrack for audio track
1cef2b2
@pylbrecht
Don't unwrap selected_index()
7a2fa83 
Fixes CRASH /html/semantics/embedded-content/the-video-element/resize-during-playback.html
@pylbrecht
Add spec reference
9f65f35
@pylbrecht
Update expectations on tests using track.onload
6937cac
@pylbrecht
Add debug!() to queue_simple_event()
4ccc66c 
To narrow down the source for TIMEOUTs, I want to know which events are
queued.
@pylbrecht
Advance ready state for PlaybackState::Playing
c9c4c77 
Strictly speaking for `PlaybackState::Playing` the ready state could be
any of

* `ReadyState::HaveCurrentData`
* `ReadyState::HaveFutureData`
* `ReadyState::HaveEnoughData`

if the previous ready state was at least `ReadyState::HaveMetadata`.

We already assume the best case (i.e. `ReadyState::HaveEnoughData`) for
`PlaybackState::Paused` and we are fixing another unexpected WPT test
result (namely `/css/selectors/media/media-playback-state.html`) by
doing the same for `PlaybackState::Playing`.
@pylbrecht
fixup! Update expectations on tests using track.onload
d662dd2
@pylbrecht
Signal EOS to player at the end of process_reponse_eof()
8e1de68
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Short videos dispatch loadedmetadata before the metadata is present
3 participants
@pylbrecht @eerii @mrobinson