New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
servoshell: add support for tabbed browsing #31545
Draft
delan
wants to merge
11
commits into
multi-tlbc
Choose a base branch
from
servoshell-tabs
base: multi-tlbc
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delan
force-pushed
the
servoshell-tabs
branch
5 times, most recently
from
March 7, 2024 10:23
5c9a9d6
to
30651a8
Compare
This was referenced Mar 7, 2024
This was referenced Mar 8, 2024
delan
force-pushed
the
servoshell-tabs
branch
2 times, most recently
from
March 11, 2024 09:03
d2fa6be
to
69dd7ac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds support for tabbed browsing in servoshell’s minibrowser, like #30785 but rebased onto #31417 and simplified to avoid current multiview and egui limitations.
For now, only one webview will be focused and shown at a time. To close a tab, click the ❌︎ in the tab bar, or middle-click the tab itself. When closing a tab that is currently focused, we switch to the next most recently focused tab.
./mach build -d
does not report any errors./mach test-tidy
does not report any errors