Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

servoshell: add support for tabbed browsing #31545

Draft
wants to merge 11 commits into
base: multi-tlbc
Choose a base branch
from
Draft

Conversation

delan
Copy link
Sponsor Member

@delan delan commented Mar 7, 2024

This patch adds support for tabbed browsing in servoshell’s minibrowser, like #30785 but rebased onto #31417 and simplified to avoid current multiview and egui limitations.

image

For now, only one webview will be focused and shown at a time. To close a tab, click the ❌︎ in the tab bar, or middle-click the tab itself. When closing a tab that is currently focused, we switch to the next most recently focused tab.


  • ./mach build -d does not report any errors
  • ./mach test-tidy does not report any errors
  • These changes fix #___ (GitHub issue number if applicable)
  • There are tests for these changes OR
  • These changes do not require tests because ___

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant