Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

script: Start rework to better match the specification HTML event loop #31505

Merged
merged 13 commits into from
May 13, 2024
Merged

script: Start rework to better match the specification HTML event loop #31505

merged 13 commits into from
May 13, 2024

Commits on May 13, 2024

  1. Fix the HTML event-loop: add a update the rendering task 

    add rendering task source

sketch structure to update the rendering

resize steps

composition events

fix warnings in rendering task source

refactor handling of composition events: put window and doc for pipeline on top

set script as user interacting in update the rendering task

fmt

add todos for other steps, put all compositor handling logic in one place

update the rendering: evaluate media queries and report changes

update the rendering: update animations and send events

update the rendering: run animation frames

update the rendering: order docs

put rendering related info on documents map

tidy

update the rendering: add issue numbers to todos

update the rendering: reflow as last step

update the rendering: add todo for top layer removals

note rendering opportunity when ticking animations for testing

fix double borrow crash in css/basic-transition

fix faster reversing of transitions test

undo ordering of docs

bypass not fully-active pipeline task throttling for rendering tasks

ensure tasks are dequed from task queue

prioritize update the rendering task

remove servo media stuff from set activity

tidy

debug

update the rendering: perform microtask checkpoint after task

tidy-up

only run evaluate media queries if resized

re-add evaluation of media queries for each rendering task, re-prioritize rendering tasks, re-add microtask checkpoint for all sequential messages

re-structure resize steps, and their interaction with evaluating media queries and reacting to environment changes

update the rendering: remove reflow call at the end

update webmessaging expectations

update to FAIL /html/browsers/browsing-the-web/navigating-across-documents/initial-empty-document/load-pageshow-events-iframe-contentWindow.html

update to FAIL load-pageshow-events-window-open.html

add issue number for ordering of docs

nits

move batching of mouse move event to document info

nits

add doc for mouse move event index

reset mouse move event index when taking pending compositor events

fix replacing mouse move event

nits
    @gterzian @mrobinson
    gterzian authored and mrobinson committed May 13, 2024
    Configuration menu
    Copy the full SHA
    91fca8d View commit details
    Browse the repository at this point in the history

  2. move update the rendering related data to document

    @gterzian @mrobinson
    gterzian authored and mrobinson committed May 13, 2024
    Configuration menu
    Copy the full SHA
    57e8fd7 View commit details
    Browse the repository at this point in the history

  3. move re-taking of tasks to try_recv

    @gterzian @mrobinson
    gterzian authored and mrobinson committed May 13, 2024
    Configuration menu
    Copy the full SHA
    a847192 View commit details
    Browse the repository at this point in the history

  4. address nits

    @gterzian @mrobinson
    gterzian authored and mrobinson committed May 13, 2024
    Configuration menu
    Copy the full SHA
    1535a8f View commit details
    Browse the repository at this point in the history

  5. change task queue try_recv into take_tasks_and_recv, with nits

    @gterzian @mrobinson
    gterzian authored and mrobinson committed May 13, 2024
    Configuration menu
    Copy the full SHA
    6fe3314 View commit details
    Browse the repository at this point in the history

  6. refactor process_pending_compositor_events

    @gterzian @mrobinson
    gterzian authored and mrobinson committed May 13, 2024
    Configuration menu
    Copy the full SHA
    280186a View commit details
    Browse the repository at this point in the history

  7. when updating the rendering, return early if script cannot continue r… 

    …unning
    @gterzian @mrobinson
    gterzian authored and mrobinson committed May 13, 2024
    Configuration menu
    Copy the full SHA
    1fc0667 View commit details
    Browse the repository at this point in the history

  8. use an instant for the last render opportunity time

    @gterzian @mrobinson
    gterzian authored and mrobinson committed May 13, 2024
    Configuration menu
    Copy the full SHA
    6dbcdc1 View commit details
    Browse the repository at this point in the history

  9. nits

    @gterzian @mrobinson
    gterzian authored and mrobinson committed May 13, 2024
    Configuration menu
    Copy the full SHA
    186761e View commit details
    Browse the repository at this point in the history

  10. remove handle_tick_all_animations

    @gterzian @mrobinson
    gterzian authored and mrobinson committed May 13, 2024
    Configuration menu
    Copy the full SHA
    9626045 View commit details
    Browse the repository at this point in the history

  11. use a vec for pending resize and compositor events

    @gterzian @mrobinson
    gterzian authored and mrobinson committed May 13, 2024
    Configuration menu
    Copy the full SHA
    9ee2bbb View commit details
    Browse the repository at this point in the history

  12. fix spec links

    @gterzian @mrobinson
    gterzian authored and mrobinson committed May 13, 2024
    Configuration menu
    Copy the full SHA
    eccaa92 View commit details
    Browse the repository at this point in the history

  13. Fix a few other nits before landing

    @mrobinson
    mrobinson committed May 13, 2024
    Configuration menu
    Copy the full SHA
    688f0ac View commit details
    Browse the repository at this point in the history