Add initial support for css-text-3 whitespace handling #29828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bors-servo try=wpt-2020 |
bors-servo
added a commit
that referenced
this pull request
Jun 1, 2023
…try> Preserve whitespace between atomic inlines White space are not preserved between atomic inlines , this PR fixes that |Before in layout 2020 | Now in layout 2020 | | --- | --- | |  |  | --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #29590 <!-- Either: --> - [ ] There are tests for these changes OR - [ ] These changes do not require tests because ___ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
|
💔 Test failed - checks-github |
|
Too many failed tests, maybe this is not the right fix? |
yeah maybe, I am looking into it. |
|
@bors-servo try=wpt-2020 |
|
@atbrakhi: 🔑 Insufficient privileges: not in try users |
|
@bors-servo try=wpt-2020 |
bors-servo
added a commit
that referenced
this pull request
Jun 2, 2023
…try> Preserve whitespace between atomic inlines White space are not preserved between atomic inlines , this PR fixes that |layout 2013 |Before in layout 2020 | Now in layout 2020 | | --- | --- | --- | |  |  |  | --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #29590 <!-- Either: --> - [ ] There are tests for these changes OR - [ ] These changes do not require tests because ___ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
|
🙁 There is no try chooser wept-2020 for this repo, try one of: linux, mac, windows, windows-rdp, wpt, wpt-2020, wpt-mac, wpt-android, android, magicleap, arm |
|
@bors-servo try=wpt-2020 @atbrakhi Can you make a PR against the servo/saltfs repository giving yourself try access? You should be able to find previous commits doing the same. |
|
🙁 There is no try chooser wept-2020 for this repo, try one of: linux, mac, windows, windows-rdp, wpt, wpt-2020, wpt-mac, wpt-android, android, magicleap, arm |
|
Test results for linux-wpt-layout-2020 from try job (#5156710924): Stable unexpected results that are known to be intermittent (1)
Stable unexpected results (16)
|
|
💥 Test timed out |
|
@bors-servo try=wpt-2020 |
|
@atbrakhi: 🔑 Insufficient privileges: not in try users |
|
@bors-servo try=wpt-2020 |
|
@bors-servo retry |
bors-servo
added a commit
that referenced
this pull request
Jun 4, 2023
…try> Preserve whitespace between atomic inlines White space are not preserved between atomic inlines , this PR fixes that |layout 2013 |Before in layout 2020 | Now in layout 2020 | | --- | --- | --- | |  |  |  | --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #29590 <!-- Either: --> - [ ] There are tests for these changes OR - [ ] These changes do not require tests because ___ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
|
Test results for linux-wpt-layout-2020 from try job (#5168191598): Flaky unexpected result (2)
Stable unexpected results that are known to be intermittent (3)
Stable unexpected results (19)
|
|
💔 Test failed - checks-github |
mrobinson
force-pushed
the
fix_white_space_not_being_preserved
branch
2 times, most recently
from
4e25277
to
a5565ef
Compare
|
@bors-servo try |
bors-servo
added a commit
that referenced
this pull request
Jul 7, 2023
…try> Preserve whitespace between atomic inlines White space are not preserved between atomic inlines , this PR fixes that |layout 2013 |Before in layout 2020 | Now in layout 2020 | | --- | --- | --- | |  |  |  | --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #29590 <!-- Either: --> - [ ] There are tests for these changes OR - [ ] These changes do not require tests because ___ <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> co-authors: @mrobinson @mukilan
|
Test results for linux-wpt-layout-2013 from try job (#5483099317): Flaky unexpected result (19)
Stable unexpected results that are known to be intermittent (12)
|
|
Test results for linux-wpt-layout-2020 from try job (#5576326084): Stable unexpected results that are known to be intermittent (1)
Stable unexpected results (122)
|
|
💥 Test timed out |
|
☔ The latest upstream changes (presumably 4f4c2a5) made this pull request unmergeable. Please resolve the merge conflicts. |
This adds initial support for whitespace handling from the CSS specification for Layout 2020. In general, the basics are covered. Since test output is very sensitive to whitespace handling, this change incorporates several fixes: 1. Whitespace is collapsed according to the Phase 1 rules of the specification, though language-specific unbreaking rules are not handled properly yet. 2. Whitespace is mostly trimmed and positioned according to the Phase 2 rules, but full support for removing whitespace at the end of lines is pending on a temporary data structure to hold lines under construction. 3. Completely empty box fragments left over immediately after line breaks are now trimmed from the fragment tree. 4. This change tries to detect when an inline formatting context collapses through. Fixes #29994. Co-authored-by: Mukilan Thiyagarajan <me@mukilan.in> Co-authored-by: Martin Robinson <mrobinson@igalia.com> Signed-off-by: Martin Robinson <mrobinson@igalia.com>
mrobinson
force-pushed
the
fix_white_space_not_being_preserved
branch
from
903639c
to
817d2e4
Compare
|
@bors-servo try=wpt-2020 |
bors-servo
added a commit
that referenced
this pull request
Jul 19, 2023
…try> Add initial support for css-text-3 whitespace handling This adds initial support for whitespace handling from the CSS specification for Layout 2020. In general, the basics are covered. Since test output is very sensitive to whitespace handling, this change incorporates several fixes: 1. Whitespace is collapsed according to the Phase 1 rules of the specification, though language-specific unbreaking rules are not handled properly yet. 2. Whitespace is mostly trimmed and positioned according to the Phase 2 rules, but full support for removing whitespace at the end of lines is pending on a temporary data structure to hold lines under construction. 3. Completely empty box fragments left over immediately after line breaks are now trimmed from the fragment tree. 4. This change tries to detect when an inline formatting context collapses through. Fixes #29994. Fixes #29590. <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #29590, #29994. - [x] There are tests for these changes
|
Test results for linux-wpt-layout-2020 from try job (#5597520591): Flaky unexpected result (4)
Stable unexpected results that are known to be intermittent (1)
|
mrobinson
force-pushed
the
fix_white_space_not_being_preserved
branch
from
817d2e4
to
947f3ad
Compare
|
@bors-servo try=wpt-2020 |
bors-servo
added a commit
that referenced
this pull request
Jul 19, 2023
…try> Add initial support for css-text-3 whitespace handling This adds initial support for whitespace handling from the CSS specification for Layout 2020. In general, the basics are covered. Since test output is very sensitive to whitespace handling, this change incorporates several fixes: 1. Whitespace is collapsed according to the Phase 1 rules of the specification, though language-specific unbreaking rules are not handled properly yet. 2. Whitespace is mostly trimmed and positioned according to the Phase 2 rules, but full support for removing whitespace at the end of lines is pending on a temporary data structure to hold lines under construction. 3. Completely empty box fragments left over immediately after line breaks are now trimmed from the fragment tree. 4. This change tries to detect when an inline formatting context collapses through. Fixes #29994. Fixes #29590. <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #29590, #29994. - [x] There are tests for these changes
mrobinson
approved these changes
Jul 19, 2023
|
Test results for linux-wpt-layout-2020 from try job (#5598614174): Flaky unexpected result (1)
|
|
💥 Test timed out |
mukilan
approved these changes
Jul 20, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds initial support for whitespace handling from the CSS
specification for Layout 2020. In general, the basics are covered. Since
test output is very sensitive to whitespace handling, this change
incorporates several fixes:
specification, though language-specific unbreaking rules are not
handled properly yet.
rules, but full support for removing whitespace at the end of lines
is pending on a temporary data structure to hold lines under
construction.
breaks are now trimmed from the fragment tree.
collapses through.
Fixes #29994.
Fixes #29590.
./mach build -ddoes not report any errors./mach test-tidydoes not report any errors