Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

servoshell: show a status bar tooltip when hovering over links #31690

Open
delan opened this issue Mar 15, 2024 · 8 comments · May be fixed by #32011
Open

servoshell: show a status bar tooltip when hovering over links #31690

delan opened this issue Mar 15, 2024 · 8 comments · May be fixed by #32011
Assignees
@iterminatorheart
Labels
A-servoshell B-newcomer Newcomer-friendly issues.

Comments

@delan
Copy link
Sponsor Member

delan commented Mar 15, 2024

When the minibrowser is enabled, add an egui tooltip to the bottom left corner when the page has status text.

Watch for EmbedderMsg::Status events, and keep track of the current status value (including None) in Minibrowser. To get the y coordinate of the bottom edge, use ui.cursor().max.y in a block that has ui, such as the TopBottomPanel show routine.

image
@rohansx
Copy link

rohansx commented Mar 17, 2024

hi @delan would like to take on this task

@delan delan added the B-newcomer Newcomer-friendly issues. label Mar 18, 2024
@delan
Copy link
Sponsor Member Author

delan commented Mar 18, 2024

Great! Feel free to add me as a reviewer if you open a pull request.

MunishMummadi added a commit to MunishMummadi/servo that referenced this issue Mar 18, 2024
@MunishMummadi
Add status tooltip, navigation buttons, and location field to TopBott…
b2a3365 
…omPanel

Closes servo#31690
@MunishMummadi MunishMummadi mentioned this issue Mar 18, 2024
Closed
4 tasks
@sandeepB3 sandeepB3 mentioned this issue Mar 19, 2024
Closed
4 tasks
@sandeepB3
Copy link
Contributor

Hey @delan , I've drafted a PR outlining my approach and the changes I've made to the files. Although ./mach build -d and ./mach test-tidy don't report any errors, the expected functionality to display a status bar tooltip when hovering over links doesn't seem to work when the minibrowser is enabled to run any website. Could you please review my draft?

@rohansx
Copy link

rohansx commented Mar 19, 2024 •
edited

@delan so should i work on this issue or not?

@MunishMummadi
Copy link
Contributor

hey @delan @rohansx . I have spent significant amount of time for refactoring and debugging my approach. Can you provide me more time to resolve the issue.

@rohansx
Copy link

rohansx commented Mar 21, 2024

@MunishMummadi Please let me know how long will it take for you to raise the PR

@iterminatorheart
Copy link
Contributor

@delan since it has passed 2 weeks, can i work on this issue

@iterminatorheart iterminatorheart linked a pull request Apr 7, 2024 that will close this issue
Open
5 tasks
@iterminatorheart
Copy link
Contributor

iterminatorheart commented Apr 7, 2024 •
edited

now i have complete this problem, please have a look @delan #32011 ，and looking forward to any feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iterminatorheart iterminatorheart

Labels
A-servoshell B-newcomer Newcomer-friendly issues.
Projects
None yet
Milestone
No milestone
5 participants
@delan @rohansx @sandeepB3 @iterminatorheart @MunishMummadi