Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow lambdas to be renamed through a new aws-lambda package #445

Conversation

lone-cloud
Copy link
Contributor

fixes #308
@danielcondemarin this is the monorepo package version of my previous PR. It appears to be working fine, but I couldn't understand the breakage going on with the tests. Pls take a look.

@lone-cloud
Copy link
Contributor Author

@danielcondemarin this should be ready for your review now.
In my despair while trying to figure out that the tests were failing due to jestjs/jest#2070, I ended up improving the tests to collect coverage from ts files.

@danielcondemarin
Copy link
Contributor

@danielcondemarin this should be ready for your review now.
In my despair while trying to figure out that the tests were failing due to facebook/jest#2070, I ended up improving the tests to collect coverage from ts files.

Great stuff. I'll test the PR probably this weekend with an aim to get it merged ASAP. Thanks.

@danielcondemarin danielcondemarin merged commit de84651 into serverless-nextjs:master Jun 21, 2020
@lone-cloud lone-cloud deleted the 308/add-aws-lambda-package branch June 22, 2020 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

defaultLambda name is not being set
2 participants