Pyproject migration #110
Open
Pyproject migration #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oupsi, it seems like I have an issue with my PR. Don't accept it |
bastiencyr
force-pushed
the
pyproject_migration
branch
2 times, most recently
from
8d398be
to
95e0b5e
Compare
|
It's ok |
bastiencyr
force-pushed
the
pyproject_migration
branch
2 times, most recently
from
167ea1b
to
7947e7b
Compare
for more information, see https://pre-commit.ci
remi-braun
reviewed
Mar 14, 2024
| @@ -0,0 +1,4 @@ | |||
| # compatibility black and flake8 | |||
| [flake8] | |||
| max-line-length = 88 | |||
There was a problem hiding this comment.
max-line-length = 200 si tu peux 😇 88 c'est trop peu j'aime pas
There was a problem hiding this comment.
En réalité ça ne change rien, la limite de 88 est la limite par défaut dans black qui n'a pas été changé dans eoreader. On respecte donc deja 88 comme longueur maximale avec Black, c'est pour ça que les tests de pré commits sont passés sans erreur.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should close #109