Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better error messages: provide node names #274

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

PhilTaken
Copy link
Collaborator

printing what node caused an error is very useful for debugging build or deployment failures, especially when deploying to several nodes at the same time

closes #273

printing what node caused an error is very useful for debugging
build or deployment failures, especially when deploying to several
nodes at the same time
@PhilTaken PhilTaken requested a review from rvem May 14, 2024 15:05
@rvem
Copy link
Member

rvem commented May 29, 2024

Won't it make sense to include the node name into higher level error constructors (namely DeployProfile and PushProfile) and re-wrap them here instead of updating PushProfileError constructors?

@PhilTaken
Copy link
Collaborator Author

Ah yes, that'd probably be a better option!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

output when deploying to multiple targets is unclear
2 participants