Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

output when deploying to multiple targets is unclear #273

Open
stuebinm opened this issue May 13, 2024 · 1 comment · May be fixed by #274
Open

output when deploying to multiple targets is unclear #273

stuebinm opened this issue May 13, 2024 · 1 comment · May be fixed by #274
Assignees
@PhilTaken

Comments

@stuebinm
Copy link

When deploying to multiple hosts in one invocation using --targets, the log output of deploy-rs is unnecessarily unclear on which host an operation affects. This is especially confusing in case one of the deployments fails, but the others succeed, as there's no obvious indication which deploy failed, only that one of them did.

As an example, consider:

❯ deploy --targets .#chaski .#flora --dry-activate -s
🚀 ℹ️ [deploy] [INFO] Evaluating flake in .
🚀 ℹ️ [deploy] [INFO] Evaluating flake in .
🚀 ℹ️ [deploy] [INFO] The following profiles are going to be deployed:
[chaski.system]
user = "root"
ssh_user = "root"
path = "/nix/store/6kj8i7d0yglnlkzpmxdn9ydz1l9l3hln-activatable-nixos-system-chaski-23.11.20240406.e38d7cb"
hostname = "chaski"
ssh_opts = []
[flora.system]
user = "root"
ssh_user = "root"
path = "/nix/store/j9wk9wy0v0xq2c0dgxh0diqvgna0wc3f-activatable-nixos-system-flora-23.11.20240406.e38d7cb"
hostname = "flora"
ssh_opts = []

🚀 ℹ️ [deploy] [INFO] Building profile `system` for node `chaski`
🚀 ℹ️ [deploy] [INFO] Building profile `system` for node `flora`
🚀 ℹ️ [deploy] [INFO] Copying profile `system` to node `chaski`
🚀 ℹ️ [deploy] [INFO] Copying profile `system` to node `flora`
🚀 ❌ [deploy] [ERROR] Failed to push profile: Nix copy command resulted in a bad exit code: Some(1)

It'd be much nicer if the log messages would simply include the hostname again, so the last line would start with 🚀 ❌ [deploy to flora] [ERROR] or something similar.
@PhilTaken PhilTaken linked a pull request May 14, 2024 that will close this issue
Draft
@PhilTaken
Copy link
Collaborator

Great suggestion, has been irking me as well!

@PhilTaken PhilTaken self-assigned this May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PhilTaken PhilTaken

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

better error messages: provide node names PhilTaken/deploy-rs
2 participants
@PhilTaken @stuebinm