Set up GitHub Actions #174

nblumhardt · 2024-03-26T01:47:59Z

This setup is via https://github.com/serilog-tracing/serilog-tracing.

I've gone for the quickest thing I could pull together, happy to tweak it here, or just merge/debug and leave it in your hands, @EEParker and @VictorioBerra :-)

Closes #173

EEParker · 2024-03-26T12:56:03Z

.github/workflows/ci.yml

+      - name: Build and Publish
+        env:
+          DOTNET_CLI_TELEMETRY_OPTOUT: true
+          NUGET_API_KEY: ${{ secrets.NUGET_API_KEY }}


Who has access to this repositories secrets? It looks like that will be required to make this work.

I've set this one up already 👍

VictorioBerra · 2024-03-26T15:53:36Z

.github/workflows/ci.yml

+          dotnet-version: 8.0.x
+      - name: Compute build number
+        run: |
+          echo "CI_BUILD_NUMBER=$(($CI_BUILD_NUMBER_BASE+200))" >> $GITHUB_ENV


Just curious, why +200?

looks like a copy/paste of https://github.com/serilog-tracing/serilog-tracing/blob/dev/.github/workflows/ci.yml

It looks like it is just to keep this incrementing and not start at 0.

Fixed, thanks

EEParker · 2024-03-26T18:02:20Z

This looks like a good start, I would also like to add something to generate release notes for tags (release versions) and use the tag name as the version number to publish to nuget.

For example:

ci-release.yml

on:
  push:
    tags:
    - '*'

# [ include content from dev build ci] [...]
    steps:
   # [...]
   - name: Create Release
      uses: ncipollo/release-action@v1
      with: 
        artifacts: "*.nupkg"
        generateReleaseNotes: true

EEParker · 2024-03-26T18:05:13Z

.gitignore

+.DS_Store
+.gitignore


can .idea/ be added to .gitignore instead of ignoring .gitignore

Argh :-) - fixed 👍

…s-splunk into gh-actions

nblumhardt · 2024-03-26T23:19:52Z

Hopefully what's there is enough to get the ball rolling now; generating release notes and using tags would be a nice improvement, unfortunately I don't have the time to roll that into this PR, but happy helping anywhere I'm needed down the line.

EEParker · 2024-03-27T16:36:42Z

Looks good, thanks for the help.

VictorioBerra · 2024-04-01T20:47:09Z

What do we think about this @EEParker? When can we test our first NuGet deployment with Actions?

EEParker · 2024-04-03T01:35:22Z

I have one small change I want to make to this, but it can be done after the merge. I want to add a separate ci for automatic releases on tags. Dev/main/master can use the branch name and build number for the pre release version.

EEParker · 2024-04-03T03:26:15Z

@VictorioBerra I have added my changes to this PR. I was able to test Build.ps1 successfully locally, but we will have to run it here to see if the actions work.

I am ready for this to be merged. It should generate a prerelease 4.0.0 build.

EEParker · 2024-04-03T04:09:20Z

nblumhardt · 2024-04-03T04:09:42Z

Good luck with the project, @EEParker and @VictorioBerra. I'll tune out regular traffic on this repo, but please @ me anytime I can help :-)

EEParker · 2024-04-03T04:10:14Z

Thank you for your assistance!

VictorioBerra · 2024-04-03T12:00:54Z

Thank you!!

* Bump System.Net.Http from 4.3.3 to 4.3.4 in /sample/Sample Bumps System.Net.Http from 4.3.3 to 4.3.4. Signed-off-by: dependabot[bot] <support@github.com> * Bump System.Net.Http from 4.3.0 to 4.3.4 in /src/Serilog.Sinks.Splunk Bumps System.Net.Http from 4.3.0 to 4.3.4. Signed-off-by: dependabot[bot] <support@github.com> * Bump System.Net.Http in /test/Serilog.Sinks.Splunk.Tests Bumps System.Net.Http from 4.3.3 to 4.3.4. Signed-off-by: dependabot[bot] <support@github.com> * Bump System.Net.Http from 4.3.0 to 4.3.4 in /src/Serilog.Sinks.UDP Bumps System.Net.Http from 4.3.0 to 4.3.4. Signed-off-by: dependabot[bot] <support@github.com> * add default batch config * Update expired GitHub Key * add default batch config * Update expired GitHub Key * fix bug dispose (#153) * Regenerate API Key for NuGet * Splunk 9.1 + .NET 6 (#166) * Sample: Target net6.0. Added additional logging statements. * Docker: Splunk 9.1. * Tests: Target net6.0 and updated nuget packages. * Added constant for services/collector. Event request trims / from uri. Updated collector URL for Splunk 9.1 * Update to serilog periodic batching 4.x (#168) * Updated dependencies to Serilog 3.1 and Periodic Batching Sink to 4.0.0 * Update version to 4.0.0 due to the breaking constructor changes on the EventCollectorSink * Update Dockerfile with net6.0 versions * Use the latest version of Splunk The 7.2 label does not appear to be available anymore. * Add in missing build for net6.0 * Use forward slash for ignore This should work on Windows as well * Use the same Framework reference for the sample Everything else is using at least net6.0 so the Sample should as well --------- Co-authored-by: Justin Pfifer <justin.pfifer@carvana.com> Co-authored-by: Jeff Parker, PE <EEParker@users.noreply.github.com> * dotnet 8.0 updates (#171) * Feature/161 subsecond decimals (#172) * Fixes #161 add subsecond decimal configuration * Fixes #167 Add a flag for RenderedMessage * Update SubSecondPrecision to use an enum. Based on 3,6,9 decimals, see https://docs.splunk.com/Documentation/Splunk/9.2.0/SearchReference/Commontimeformatvariables * Add unit tests and update documentation * Invert renderMessage check * Update sample docker-compose project - add new tests - add a docker-compose vscode project - allow subsecond precision. * Add comment for configuring splunk * Fix formatting for nanoseconds * Enable all tests in sample app --------- Co-authored-by: Victorio Berra <toryberra@gmail.com> * Set up GitHub Actions (#174) * Enable GitHub Actions * Main branch is called master in this repo * Ignore .idea * No need to offset builds by 200 * work on build for new project format * add automatic release notes --------- Co-authored-by: EEParker <EEParker@users.noreply.github.com> * Filter branches that push to nuget (#177) * Security Policy, scanning and dependency updates (#176) * Add dependabot configuration * Add codeql * Add security policy * Update dependabot.yml add newline * update branches * Update SECURITY.md * Readme and package license fix * Update dotnet pack command line --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Matthew Erbs <matthew.erbs@merbla.com> Co-authored-by: Mohsen Rajabi <m.kabir8895@gmail.com> Co-authored-by: Havagan <Havagan@users.noreply.github.com> Co-authored-by: Justin Pfifer <61801015+jpfifer@users.noreply.github.com> Co-authored-by: Justin Pfifer <justin.pfifer@carvana.com> Co-authored-by: Victorio Berra <toryberra@gmail.com> Co-authored-by: Nicholas Blumhardt <nblumhardt@nblumhardt.com>

nblumhardt added 2 commits March 26, 2024 11:45

Enable GitHub Actions

f111c87

Main branch is called master in this repo

ba3c5dd

EEParker mentioned this pull request Mar 26, 2024

Feature/161 subsecond decimals #172

Merged

EEParker reviewed Mar 26, 2024

View reviewed changes

VictorioBerra reviewed Mar 26, 2024

View reviewed changes

EEParker reviewed Mar 26, 2024

View reviewed changes

nblumhardt added 3 commits March 27, 2024 09:12

Ignore .idea

5fb3cde

No need to offset builds by 200

e3018dc

Merge branch 'dev' of https://github.com/serilog-contrib/serilog-sink…

e6d11bd

…s-splunk into gh-actions

EEParker added 2 commits April 2, 2024 22:08

work on build for new project format

9537e3b

add automatic release notes

cea927d

EEParker added enhancement Semver-Major Major Update - breaking changes Semver-Minor Minor Update - non-breaking changes and removed Semver-Major Major Update - breaking changes Semver-Minor Minor Update - non-breaking changes labels Apr 3, 2024

EEParker added this to the 4.0 milestone Apr 3, 2024

EEParker merged commit 55d211c into serilog-contrib:dev Apr 3, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Set up GitHub Actions #174

Set up GitHub Actions #174

nblumhardt commented Mar 26, 2024 •

edited by EEParker

EEParker Mar 26, 2024

nblumhardt Mar 26, 2024

VictorioBerra Mar 26, 2024

EEParker Mar 26, 2024

EEParker Mar 26, 2024

nblumhardt Mar 26, 2024

EEParker commented Mar 26, 2024 •

edited

EEParker Mar 26, 2024

nblumhardt Mar 26, 2024

nblumhardt commented Mar 26, 2024

EEParker commented Mar 27, 2024

VictorioBerra commented Apr 1, 2024

EEParker commented Apr 3, 2024 •

edited

EEParker commented Apr 3, 2024 •

edited

EEParker commented Apr 3, 2024

nblumhardt commented Apr 3, 2024

EEParker commented Apr 3, 2024

VictorioBerra commented Apr 3, 2024

		.DS_Store
		.gitignore

Set up GitHub Actions #174

Set up GitHub Actions #174

Conversation

nblumhardt commented Mar 26, 2024 • edited by EEParker

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

EEParker commented Mar 26, 2024 • edited

ci-release.yml

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nblumhardt commented Mar 26, 2024

EEParker commented Mar 27, 2024

VictorioBerra commented Apr 1, 2024

EEParker commented Apr 3, 2024 • edited

EEParker commented Apr 3, 2024 • edited

EEParker commented Apr 3, 2024

nblumhardt commented Apr 3, 2024

EEParker commented Apr 3, 2024

VictorioBerra commented Apr 3, 2024

nblumhardt commented Mar 26, 2024 •

edited by EEParker

EEParker commented Mar 26, 2024 •

edited

EEParker commented Apr 3, 2024 •

edited

EEParker commented Apr 3, 2024 •

edited