Follow rollup virtual module convention

sergix44 · Apr 13, 2024 · aebaa9d · aebaa9d
1 parent fd4f12c
commit aebaa9d
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 7 deletions.
diff --git a/package.json b/package.json
@@ -33,7 +33,7 @@
   },
   "scripts": {
     "tests": "vitest --run",
-    "prepublishOnly": "tsup ./src --external virtual:laravel-translations --format cjs,esm --dts"
+    "prepublishOnly": "tsup ./src --external virtual-laravel-translations --format cjs,esm --dts"
   },
   "repository": {
     "type": "git",

diff --git a/src/index.ts b/src/index.ts
@@ -1,6 +1,6 @@
 import {Config, translator} from './translator'
 // @ts-ignore
-import translations from '\0laravel-translations'
+import translations from 'virtual-laravel-translations'
 
 declare global {
     interface Window {

diff --git a/src/vite.ts b/src/vite.ts
@@ -13,19 +13,20 @@ export default function laravelTranslator(options: string | VitePluginOptionsInt
     const additionalLangPaths = typeof options === 'string' ? [] : options.additionalLangPaths ?? []
     const frameworkLangPath = 'vendor/laravel/framework/src/Illuminate/Translation/lang/'.replace('/', path.sep)
 
-    const moduleId = '\0laravel-translations'
+    const virtualModuleId = 'virtual-laravel-translations'
+    const resolvedVirtualModuleId = '\0' + virtualModuleId
 
     const paths = [frameworkLangPath, langPath, ...additionalLangPaths]
     return {
         name: 'laravel-translator',
         resolveId(id) {
-            if (id === moduleId) {
-                return moduleId
+            if (id === virtualModuleId) {
+                return resolvedVirtualModuleId
             }
             return null
         },
         load(id) {
-            if (id === moduleId) {
+            if (id === resolvedVirtualModuleId) {
                 return `export default ${JSON.stringify(exportTranslations(...paths))}`
             }
             return null
@@ -35,7 +36,7 @@ export default function laravelTranslator(options: string | VitePluginOptionsInt
                 const relative = path.relative(lp, ctx.file);
                 const isSub = relative && !relative.startsWith('..') && !path.isAbsolute(relative);
                 if (isSub) {
-                    const virtualModule = ctx.server.moduleGraph.getModuleById(moduleId)!;
+                    const virtualModule = ctx.server.moduleGraph.getModuleById(resolvedVirtualModuleId)!;
                     ctx.server.moduleGraph.invalidateModule(virtualModule)
                     ctx.server.ws.send({
                         type: 'full-reload',