Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UploadController] Response now includes a raw_url field #533

Merged
merged 1 commit into from
May 31, 2023

Conversation

cursey
Copy link
Contributor

@cursey cursey commented May 30, 2023

I have sharex configured to add /raw to the end of every uploaded file automatically but that results in broken .gif thumbnails in discord and requires extra configuration steps.

This change just includes a properly formatted raw_url field in the /upload response that can be used more easily from sharex and creates working gif thumbnails in discord.

Note: The broken gif thumbnails in discord seems to be entirely discords fault. I think they're just looking at the URL and seeing if it ends in .gif which is why this change fixes that behavior.

@angelfor3v3r
Copy link

angelfor3v3r commented May 30, 2023

I tested this out on an instance I'm running and it does indeed fix my issue at #493. The only thing I had to do is change my ShareX config to read the raw_url instead. It seems like certain sites/apps specifically look for extensions + a raw site (i.e. without the XBackBone interface). The "copy raw url" mode exists which does exactly this, I guess it only makes sense to have it available in the API too? Perhaps down the line an option in the user settings page to generate the ShareX config with this in already set would be nice, too.

Closes #493

@sergix44 sergix44 merged commit 0951638 into sergix44:master May 31, 2023
7 checks passed
@cursey cursey deleted the feature/upload-response-raw-url branch May 31, 2023 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants